Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set _isMounted to true after component mounted #700

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Set _isMounted to true after component mounted #700

merged 1 commit into from
Jul 14, 2020

Conversation

janus-reith
Copy link
Collaborator

@janus-reith janus-reith commented Jul 10, 2020 •
edited

Signed-off-by: Janus Reith mail@janusreith.de

Resolves #699
Impact: minor
Type: bugfix

Issue

In 0ae583e#diff-9b6019bce1be1df5431a56f4a139663dL77 I removed the whole componentDidMount part, not realizing that this._isMounted = true; was unrelated to the tracking events underneath.

Solution

Add back a componentDidMount lifecycle function to set _isMounted to true in the first place.
Don't close #699 until confirmed that there is no separate issue present on older versions, where the component might actually not be mounted properly.

Testing

See #699

Set _isMounted to true after component mounted
53a2bd1 
Signed-off-by: Janus Reith <mail@janusreith.de>
manueldelreal
manueldelreal approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionally it seems to be ok, I was able to checkout, and get an error message when using stripe and when disallowing guest checkout (to avoid IOU from completing)

@janus-reith janus-reith mentioned this pull request Jul 14, 2020
Closed
willopez
willopez approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez
Copy link
Member

Thanks @janus-reith!

@willopez willopez merged commit 99b3003 into reactioncommerce:trunk Jul 14, 2020
@kieckhafer kieckhafer mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

@manueldelreal manueldelreal manueldelreal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

infinite loader if the payment is rejected
3 participants
@janus-reith @willopez @manueldelreal