Don't get shop to pre-render page

[Akarshit]

Resolves #742
Impact: critical
Type: bugfix

Issue

The cart page was being saved on build time, which was causing the shop to null as there was no server to get the shop from during build time.
Also the all the pages were being re-built after 2 mins, because of a wrong variable check.

Solution

Now the shop would be fetched from the backend on every request. Fixed the variable check to recreate the page when the shop is not present.

Breaking changes

None expected.

Testing

1. Start the platform using make
2. Stop reaction_api using docker stop reaction_api_1. This would simulate the circle CI build env in which the server is not running.
3. Build the example-storefront image using docker build --network=host -t reactioncommerce/example-storefront:test-me . in example-storefront directory
4. Once complete get the server back up using make init-reaction
5. Run the new image using docker run -it --name storefront -p 4000:4000 --env-file .env.prod --network reaction.localhost reactioncommerce/example-storefront:test-me. If you get an error that /storefront is being used by XXX, do docker rm XXX
6. Login, try adding products to cart, go to cart page. Everything should work.

There are other pages that use unstable_revalidate, but I was getting very sketchy behavior on the first load using that. So I thought it might be better to remove SSR for now, and if needed people can extend and add that according to their need. The behaviour is explained in the linked issue.

[janus-reith]

I feel like there should be a general solution to this: #718

Yes, the api would need to be reachable during build time currently.
I tried to point out some potential way to change that in the linked issue.

I doubt however that fully opting out and server-rendering per request instead is a better solution to this.

[Akarshit]

The build is failing because of some other reason. I can see that happening in other PRs too.

[jrw421]

Hey @Akarshit - I just followed the steps listed to test and still get the same bug. Am I missing something? 🤔

[Akarshit]

@jrw421 Hmm, can't say for sure. We can do a quick screen-sharing session to sort this out...

[jrw421]

Tested and looks good! 🎉