Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding git hooks for commit-msg #753

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Conversation

Akarshit
Copy link
Contributor

@Akarshit Akarshit commented Feb 4, 2021

Resolves #752
Impact: minor
Type: chore

Issue

No commit-msg hooks, so the commit message were a little out of consistency.

Solution

Adding commit-msg hooks using husky.

Breaking changes

None

Testing

  1. Pull the branch.
  2. Run npm i
  3. Make some edit.
  4. Try to commit, something weird like "this is a invalid commit". The hooks should fail.
  5. Fix the messge to something like "fix: valid commit", you should see the commit succeed.

@jrw421
Copy link
Contributor

jrw421 commented Feb 4, 2021

Think this may need to be updated with trunk because of the build failure.

@Akarshit
Copy link
Contributor Author

Akarshit commented Feb 4, 2021

@jrw421 It was an issue with me using npm instead of yarn

Signed-off-by: Akarshit Wal <akarshit.wal@mailchimp.com>
@Akarshit Akarshit merged commit 214810b into trunk Feb 11, 2021
@Akarshit Akarshit deleted the chore-752-precommit-hooks branch February 11, 2021 20:38
@Akarshit Akarshit mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit hooks for linting commit message
2 participants