Update to Meteor 2.0, React 16.14.0 and enable HMR #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loan Laux <loan@outgrow.io>
Signed-off-by: Loan Laux <loan@outgrow.io>
Signed-off-by: Loan Laux <loan@outgrow.io>
Signed-off-by: Loan Laux <loan@outgrow.io>
|
Let's wait until the |
Signed-off-by: Loan Laux <loan@outgrow.io>
…to loan-update-meteor-2.0 Signed-off-by: Loan Laux <loan@outgrow.io>
|
@loan-laux Can you please update the PR with latest trunk, I tried doing that but I don't have write permission to your org. |
|
@Akarshit Done. ✅ |
Signed-off-by: Loan Laux <loan@outgrow.io>
Akarshit
approved these changes
Feb 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: performance|chore
Issue
Meteor was outdated as version 2.0 recently came out. This version introduces HMR with React Fast Refresh, making for a better developer experience when working on the front-end.
Solution
Update to Meteor 2.0. Also update to React 16.14.0 as HMR needs React > 16.9.0 to work and we were running 16.8.6.
Breaking changes
None.
Testing
reaction-admin, check that the UI is working as it should.