Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Product editor does not detect publishable changes sometimes #347

Merged
merged 5 commits into from
Feb 15, 2021

Conversation

jrw421
Copy link
Contributor

@jrw421 jrw421 commented Feb 12, 2021

Signed-off-by: jrw421 jessica.wolvington@gmail.com

Resolves #251
Impact: major
Type: bugfix

Issue

The product editor sometimes does not detect publishable changes.

Solution

Sometimes on a form update the product hashes would not update to enable the publish button. By refetching the product on an update of the product or a variant the product hashes are the most up to date and the publish button is correctly enabled.

Breaking changes

None expected.

Testing

  1. Create a new product and add basic information, including an attribute label to the variant, save and publish.
  2. Add price to the variant and save.
  3. Edit basic information in the product or variant and save.
  4. Observe publish button is now enabled after each save.

…le changes

Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
Signed-off-by: jrw421 <jessica.wolvington@gmail.com>
@jrw421 jrw421 requested a review from a team February 12, 2021 15:41
Copy link
Contributor

@MohanNarayana MohanNarayana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@jrw421 jrw421 merged commit a1d4bac into trunk Feb 15, 2021
@jrw421 jrw421 deleted the fix-251-jrw421-publishable-changes branch February 15, 2021 21:03
@loan-laux loan-laux mentioned this pull request Feb 28, 2021
2 tasks
@Akarshit Akarshit mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product editor does not detect publishable changes sometimes
2 participants