Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pricing instead of price in products query #352

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

loan-laux
Copy link
Contributor

Signed-off-by: Loan Laux loan@outgrow.io

Resolves #288
Impact: minor
Type: bugfix

Issue

The products query is fetching prices by querying the price field which has been deprecated.

Solution

Query pricing instead of price.

Breaking changes

None.

Testing

  1. Open the Products page and make sure there are products in the table.
  2. Check the API logs and notice there are no deprecation warnings anymore.

Signed-off-by: Loan Laux <loan@outgrow.io>
@Akarshit Akarshit merged commit 36d92db into reactioncommerce:trunk Feb 26, 2021
@Akarshit Akarshit mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get deprecation warning when using latest version of admin
2 participants