Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(regioninput): add RegionInput component, use in AddressForm #354

Merged
merged 8 commits into from Nov 2, 2018
Merged

feat(regioninput): add RegionInput component, use in AddressForm #354

merged 8 commits into from Nov 2, 2018

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Nov 1, 2018 •
edited

Resolves #345
Impact: minor
Type: feature

RegionInput

AddressForm

  • Refactors AddressForm to use RegionInput

Fixes

Testing

  1. RegionInput: https://deploy-preview-354--stoic-hodgkin-c0179e.netlify.com/#!/RegionInput
  2. AddressForm: https://deploy-preview-354--stoic-hodgkin-c0179e.netlify.com/#!/AddressForm

@rc-publisher
Copy link
Collaborator

rc-publisher commented Nov 1, 2018 •
edited

🚀 Preview deployed

Built with commit a9806dd

https://deploy-preview-354--stoic-hodgkin-c0179e.netlify.com

@machikoyasuda machikoyasuda changed the title wip - feat(regioninput): add RegionInput component, use in AddressForm feat(regioninput): add RegionInput component, use in AddressForm Nov 1, 2018
@machikoyasuda machikoyasuda added this to the Quandary milestone Nov 1, 2018
aldeed
aldeed requested changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@aldeed aldeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments

package/src/components/RegionInput/v1/RegionInput.js Outdated Show resolved Hide resolved
package/src/components/AddressForm/v1/AddressForm.js Outdated Show resolved Hide resolved
package/src/components/RegionInput/v1/RegionInput.js Show resolved Hide resolved
@machikoyasuda
Copy link
Contributor Author

@aldeed Ready for re-review!

@aldeed aldeed merged commit 51a8816 into master Nov 2, 2018
@aldeed aldeed deleted the 345-machikoyasuda-regioninput-component branch November 2, 2018 18:06
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 0.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldeed aldeed aldeed approved these changes

@nnnnat nnnnat Awaiting requested review from nnnnat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Quandary
Development

Successfully merging this pull request may close these issues.

RegionInput component
3 participants
@machikoyasuda @rc-publisher @aldeed