Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Guide updates #241

Merged
merged 8 commits into from
Oct 4, 2017
Merged

Style Guide updates #241

merged 8 commits into from
Oct 4, 2017

Commits on Jul 26, 2017

  1. Updated styleguide 

    - of course, we’ll have some updates to make following this!
    aaronjudd committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    3959628 View commit details
    Browse the repository at this point in the history

  2. Add code review docs 

    - start a list of code review requirements
    aaronjudd committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    e0da73c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2017

  1. Updated review/styleguide

    aaronjudd committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    efe945b View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2017

  1. Merge branch 'master' into style-guide-reviews

    Aaron Judd committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    5c2cf71 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. Update code-review 

    Add details on what happens post-merge, how triage happens, and exact commands to run before you make a PR.
    @machikoyasuda
    machikoyasuda committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    b8c2e0f View commit details
    Browse the repository at this point in the history

  2. Update style guide with JS recommendations from team

    @machikoyasuda
    machikoyasuda committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    e672d9a View commit details
    Browse the repository at this point in the history

  3. Update styleguide.md

    @machikoyasuda
    machikoyasuda committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    190b0d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2017

  1. Update styleguide.md

    @machikoyasuda
    machikoyasuda committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    345a9ed View commit details
    Browse the repository at this point in the history