Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sending email async #1200

Closed
brent-hoover opened this issue Jul 25, 2016 · 1 comment
Closed

Make sending email async #1200

brent-hoover opened this issue Jul 25, 2016 · 1 comment
Assignees
@brent-hoover @jshimko
Milestone
v0.16.0

Comments

@brent-hoover
Copy link
Collaborator

brent-hoover commented Jul 25, 2016 •
edited by aaronjudd
Loading

In several places (most notably at order completion) the application fully blocks on sending email. This makes the app appear to stall. (also when marking an order shipped)

Sending of email should be moved into job so that it can be properly retried if there is an actual failure and proper logs are sent.

We have talked about this a couple of times just creating this ticket this so it might get worked on as part of the RC 16 email goals.
@aaronjudd aaronjudd added this to the v0.16.0 milestone Aug 4, 2016
@aaronjudd aaronjudd added the ready label Aug 4, 2016
@brent-hoover brent-hoover mentioned this issue Aug 5, 2016
Closed
@jshimko jshimko self-assigned this Aug 8, 2016
@jshimko jshimko added in progress and removed ready labels Aug 9, 2016
@jshimko jshimko mentioned this issue Aug 11, 2016
Merged
@aaronjudd aaronjudd modified the milestones: v0.15.0, v0.16.0 Aug 16, 2016
@aaronjudd
Copy link
Contributor

Resolved by #1282

@brent-hoover brent-hoover mentioned this issue Aug 18, 2016
Merged
@aaronjudd aaronjudd removed the review label Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brent-hoover brent-hoover

@jshimko jshimko

Labels
None yet
Projects
None yet
Milestone
v0.16.0
Development

No branches or pull requests
3 participants
@brent-hoover @aaronjudd @jshimko