Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move languageDirection out of translation #1510

Closed
aaronjudd opened this issue Oct 19, 2016 · 0 comments
Closed

move languageDirection out of translation #1510

aaronjudd opened this issue Oct 19, 2016 · 0 comments
Assignees
@aaronjudd

Comments

@aaronjudd
Copy link
Contributor

aaronjudd commented Oct 19, 2016 •
edited

in en.json (and all other translations), the key languageDirection needs to move out of the translation node, to the top level meta data. This is because the translation services recognize the meta data to be that (not needing translation), but the translation data is converted, so translators put a variety of values in there, but in reality it's not a translation phrase.
@aaronjudd aaronjudd added the i18n label Oct 19, 2016
aaronjudd pushed a commit that referenced this issue Oct 20, 2016
use i18next.dir to determine language direction
5761e77 
- Resolves #1510
- Use `i18next.dir()` to determine language direction.
@aaronjudd aaronjudd mentioned this issue Oct 20, 2016
Merged
@aaronjudd aaronjudd self-assigned this Oct 20, 2016
aaronjudd pushed a commit that referenced this issue Oct 25, 2016
I18n translations (#1514)
7f8cfd2 
* LingoHub Update 🚀

Manual push by LingoHub User: Aaron Judd.
Project: reaction

Made with ❤️ by https://lingohub.com

* LingoHub Update 🚀

Manual push by LingoHub User: Aaron Judd.
Project: reaction

Made with ❤️ by https://lingohub.com

* use i18next.dir to determine language direction

- Resolves #1510
- Use `i18next.dir()` to determine language direction.

* deprecate languageDirection
@ghost ghost removed the review label Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronjudd aaronjudd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronjudd