Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After simple-schema update, Re-enable validation #2806

Closed
spencern opened this issue Sep 7, 2017 · 4 comments
Closed

After simple-schema update, Re-enable validation #2806

spencern opened this issue Sep 7, 2017 · 4 comments
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects

Comments

@spencern
Copy link
Contributor

spencern commented Sep 7, 2017

From @zenweasel on the #2791 PR

Note It should be super awesome if we could have Simple-Schema enforce that all shipping records need to contain a shopId but I could not get this to work. (I removed the blackbox record to make it validate, but it threw all sort of errors). I don't think this should block us now but I would like to revisit this as soon as we make the change to node-simple-schema.

When we update to node-simple-schema in #1343, we should check to make sure that we're validating all records on cart and orders as well. Mostly by removing blackbox: true on most subschemas

@spencern spencern added the chore For issues that describe a task that does not affect the release, such as tests or CI configuration label Sep 7, 2017
@brent-hoover brent-hoover changed the title After simple-schema update, validate shipping records After simple-schema update, Re-enable validation Sep 7, 2017
@brent-hoover
Copy link
Collaborator

I would make this broader to re-enable all validations that are currently disabled with blackbox: true

@spencern
Copy link
Contributor Author

spencern commented Sep 7, 2017

Some of the blackbox: true settings are so that we can handle future plugins that may not fit a given schema I think - e.g. payment transactions.

@brent-hoover
Copy link
Collaborator

Right, so maybe not all, but certainly in the cases where we rely on the data being consistent.

@aldeed
Copy link
Contributor

aldeed commented Jul 9, 2019

Resolved in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
No open projects
Core
Awaiting triage
Development

No branches or pull requests

3 participants