Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product detail display issue on mobile #37

Closed
bstocks opened this issue Apr 14, 2014 · 4 comments
Closed

Product detail display issue on mobile #37

bstocks opened this issue Apr 14, 2014 · 4 comments

Comments

@bstocks
Copy link
Contributor

bstocks commented Apr 14, 2014

When logged in as admin, the product detail view has horizontal scroll bar and some elements extend beyond the screen. This happens when the viewport goes below 768px and the elements all stack.

screen shot 2014-04-14 at 8 54 05 am

@bstocks bstocks added the bug label Apr 14, 2014
@aaronjudd
Copy link
Contributor

This is only in admin, it's the "edit" icon on the variant. Not sure what to do to that icon in the small screen size. ideas?

@bstocks
Copy link
Contributor Author

bstocks commented Jun 19, 2014

A couple thoughts on this:

  1. The variant bar could be made less wide on smaller screen sizes to leave room for the edit icon.

screen shot 2014-06-19 at 2 44 53 pm

  1. On smaller screen sizes the edit icon could move inside the bar directly to the left of the price.

screen shot 2014-06-19 at 2 42 28 pm

I think most people will be on touch devices at these small sizes, so the second idea might make more sense since you'll just tap the bar anyway (and that little icon is a very small target).

@aaronjudd
Copy link
Contributor

or just remove it and allow the double tap to be the trick. (also, minor thing, but then we'd lose a couple characters from the title to the pen)

@bstocks
Copy link
Contributor Author

bstocks commented Jun 19, 2014

I like that. Removing it on small screens altogether is probably the simplest answer.

zenweasel pushed a commit that referenced this issue Sep 20, 2022
…86d941a6e3cebd8b59f3d

[Snyk] Upgrade @reactioncommerce/api-utils from 1.16.0 to 1.16.5
zenweasel pushed a commit that referenced this issue Sep 20, 2022
…path-parse-1.0.7

chore(deps): Bump path-parse from 1.0.6 to 1.0.7
zenweasel pushed a commit that referenced this issue Sep 20, 2022
zenweasel pushed a commit that referenced this issue Sep 20, 2022
…validator-13.7.0

chore(deps): Bump validator from 13.6.0 to 13.7.0
zenweasel pushed a commit that referenced this issue Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants