Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product detail image gallery has strange behavior #43

Closed
bstocks opened this issue Apr 14, 2014 · 6 comments
Closed

Product detail image gallery has strange behavior #43

bstocks opened this issue Apr 14, 2014 · 6 comments
Assignees
Milestone

Comments

@bstocks
Copy link
Contributor

bstocks commented Apr 14, 2014

After adding a second image to the gallery:

silicon beach tee
silicon beach tee1
silicon beach tee2

@bstocks bstocks added the bug label Apr 14, 2014
@saarmstrong saarmstrong self-assigned this May 5, 2014
@saarmstrong saarmstrong added this to the Alpha milestone May 5, 2014
@saarmstrong
Copy link
Contributor

We need to swap the selected image / primary image on mouseover:

http://jsfiddle.net/saarmstrong/j4R37/2/

@saarmstrong
Copy link
Contributor

15dfc6aa8e7b21bbfd59a2b191fa754083b9e32a Fixes #43: made product detail image gallery work better

@aaronjudd aaronjudd reopened this May 8, 2014
@aaronjudd
Copy link
Contributor

Looks like this broke drag and drop re-ordering of images when user is an admin. When the normal user just hovers off image gallery some funkiness is happening where the gallery shows multiple images that aren't really the images that are supposed to be there as well. In the screenshots below there should be 5 unique images.

screenshot 2014-05-08 09 39 21
screenshot 2014-05-08 09 39 15

@saarmstrong
Copy link
Contributor

  • added img element to contain selected image and no longer fade out selected image
  • fixed sorting of images in the gallery when using drag and drop

@aaronjudd
Copy link
Contributor

screenshot 2014-05-11 08 02 09

Drag and drop seems to be working, but the primary image display doesn't always work.

@aaronjudd aaronjudd reopened this May 11, 2014
@saarmstrong
Copy link
Contributor

Updated the JS to swap images on mouseenter. Admin reordering will reactively update end user images, but complete ordering will only be displayed on page refresh.

cmbirk pushed a commit to cmbirk/reaction that referenced this issue Aug 18, 2019
…pdate-radial-payment-to-1.0.0

Update radial payment to 1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants