Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tax and inventory toggles are not working #4401

Closed
3 tasks done
jamesporl opened this issue Jul 4, 2018 · 4 comments · Fixed by #4338
Closed
3 tasks done

Tax and inventory toggles are not working #4401

jamesporl opened this issue Jul 4, 2018 · 4 comments · Fixed by #4338
Assignees

Comments

@jamesporl
Copy link
Contributor

jamesporl commented Jul 4, 2018

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?
  • Did you search the issue queue for existing issue? Search issues

Issue Description

In product detail form, the toggle switches in tax and inventory sections cannot be toggled.

Steps to Reproduce

  1. Edit a product variant.
  2. Try to toggle the switches in the tax and inventory sections. From the UI, the switches will not "react."
  3. Refresh the page and you will see that the switches were actually toggled.

Possible Solution

Update the components/autoform

Versions

Node: 8.11.2
NPM: 5.6.0
Meteor Node: 8.11.2
Meteor NPM: 5.10.0
Reaction CLI: 0.29.0
Reaction: 1.14.0
Reaction branch: 1.14.0
@zenweasel
Copy link
Collaborator

What are you basing "they don't do anything" on and why would that mean removing them and not making them work?

@jamesporl
Copy link
Contributor Author

Hmm. I just assumed that the toggle switches did nothing because I'm unable to toggle them. But looking at the product collection, these switches correspond to some fields and should be fixed to work instead of hiding them.

I'm revising this issue.

@jamesporl jamesporl changed the title Tax and inventory toggles should be hidden in product detail form Tax and inventory toggles are not working Jul 4, 2018
@jamesporl jamesporl self-assigned this Jul 6, 2018
@zenweasel
Copy link
Collaborator

This does not appear to be fixed

@zenweasel zenweasel reopened this Jul 17, 2018
spencern added a commit that referenced this issue Jul 18, 2018
…tory-toggles-not-working-2

(fix) #4401 Tax and inventory toggle switches do not work (2)
@spencern
Copy link
Contributor

Closed by #4445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants