Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SetEmailOnAnonymousCartInput to use cartToken instead of token param name #4642

Closed
willopez opened this issue Sep 18, 2018 · 6 comments
Closed

Update SetEmailOnAnonymousCartInput to use cartToken instead of token param name #4642

willopez opened this issue Sep 18, 2018 · 6 comments
Labels
good first issue For issues that a new contributor could likely submit a pull request for without needing much help help wanted For issues that have a clear solution described and are not currently prioritized core team work

Comments

@willopez
Copy link
Member

Summary

SetEmailOnAnonymousCartInput, RemoveCartItemsInput and perhaps others input types, use a param named token to required the request to provide an anonymous cart token, other input types use cartToken such as SelectFulfillmentOptionForGroupInput. This inconsistency leads to unnecessary client code. Lets add consistency by using cartToken as the param name for all inputs.
@nnnnat nnnnat added this to the North Maroon milestone Sep 19, 2018
@spencern spencern modified the milestones: North Maroon, Oxford Oct 2, 2018
@spencern spencern removed this from the Oxford milestone Oct 18, 2018
@spencern spencern added impact-minor help wanted For issues that have a clear solution described and are not currently prioritized core team work good first issue For issues that a new contributor could likely submit a pull request for without needing much help labels Oct 18, 2018
@codejockie
Copy link
Contributor

codejockie commented Oct 19, 2018 •
edited
Loading

Hey @willopez, I would like to work on this task. It been a long time, a lot has changed. I have forked the repo, how do I setup to run locally and start pushing?

@Aberman12
Copy link

I can take this issue on if its still available

@willopez
Copy link
Member Author

willopez commented Mar 11, 2019 •
edited
Loading

It would be great to have either one of you work on this issue. Here is a tutorial on how to setup Reaction 2.0
https://blog.reactioncommerce.com/tutorial-how-to-set-up-your-dev-environment-for-reaction/
And I can answer questions if needed.

@richPurba
Copy link

richPurba commented May 20, 2019 •
edited
Loading

@willopez Please provide me the access to the spreadsheet above, as i am thinking to help as well

@willopez
Copy link
Member Author

@richPurba I have updated the link to the getting started tutorial.

This was referenced Nov 21, 2019
Merged
Merged
@willopez
Copy link
Member Author

willopez commented Dec 6, 2019

resolved in #5820

@willopez willopez closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For issues that a new contributor could likely submit a pull request for without needing much help help wanted For issues that have a clear solution described and are not currently prioritized core team work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@willopez @nnnnat @spencern @richPurba @codejockie @Aberman12