-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cart token param name consistent to cartToken
#5820
refactor: cart token param name consistent to cartToken
#5820
Conversation
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
… into refactor-4642-make-cartToken-consistent
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
…nymousCartByCartId query Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
Signed-off-by: trojanh <rajan.tiwari@kiprosh.com>
27a96b8
to
2f0d3df
Compare
cartToken
cartToken
@trojanh These changes look good but I don't want to merge this until the |
I have made the changes for front-end, |
I reviewed and merged the related PR on the storefront reactioncommerce/example-storefront#616 this one is good to go too. Thanks again @trojanh |
Resolves #4642
Impact: minor
Type: refactor
Issue
Cart tokens currently have three names i.e
token
,cartToken
andanonymousAccessToken
, need to rename all of them to same consistent name.Solution
Update
token
oranonymousAccessToken
params name tocartToken
to make it consistentBreaking Changes
Clients (such as those based on the example storefront codebase) that call cart-related mutations will need to pass
cartToken
param instead oftoken
oranonymousAccessToken
Testing
Test the following mutations:
updateCartItemsQuantity
setEmailOnAnonymousCart
removeCartItems
reconcileCarts
addCartItems
Test following query
anonymousCartByCartId