Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1524 - Type Error thrown by empty addressBook #1525

Merged
merged 4 commits into from
Oct 25, 2016
Merged

Fixes #1524 - Type Error thrown by empty addressBook #1525

merged 4 commits into from
Oct 25, 2016

Commits on Oct 24, 2016

  1. Fixes reactioncommerce#1524 

    Error was caused by `fieldData.addressBook` existing as an empty array, this checks to make sure that `addressBook[0]` exists before looking for the `fullName` prop.
    @spencern
    spencern committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    50a9132 View commit details
    Browse the repository at this point in the history

  2. fix camelcase typo that was breaking tests.

    @spencern
    spencern committed Oct 24, 2016
    1 Configuration menu
    Copy the full SHA
    4479fad View commit details
    Browse the repository at this point in the history

  3. Actually fix typo in addressBook. 

    Previous commit is what happens when you have two editor windows open with similar files open.
    @spencern
    spencern committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    20509b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2016

  1. Merge branch 'development' into spencer-fix-1524-type-error

    Aaron Judd committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    0dd3d00 View commit details
    Browse the repository at this point in the history