Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If default provider is not available, then add it. #2025

Merged
merged 2 commits into from Mar 23, 2017
Merged

If default provider is not available, then add it. #2025

merged 2 commits into from Mar 23, 2017

Conversation

zenweasel
Copy link
Collaborator

@zenweasel zenweasel commented Mar 22, 2017 •
edited

Resolves #2018

I decided on this method although I think it could be equally valid to say "you need to import the default method if you are going to modify them". Also maybe there is a better way to change that validation so you can still use the ShippingMethod schema?

How to test:

  1. Delete the included Shipping.json
  2. reaction reset && reaction
  3. Go to the Shipping dashboard
  4. Enable Flat Rates
  5. Observe there are no rates there
  6. Click on the plus sign
  7. Fill out the fields
  8. Observe that you have added a rate.

mikemurray
mikemurray approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

impactmass
impactmass approved these changes Mar 23, 2017
View reviewed changes
Copy link
Contributor

@impactmass impactmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works according to the steps. 🎉

@zenweasel zenweasel merged commit 7bef22b into development Mar 23, 2017
@zenweasel zenweasel removed the review label Mar 23, 2017
@zenweasel zenweasel deleted the brent-fix-issue-2018 branch March 23, 2017 08:26
@zenweasel zenweasel mentioned this pull request Mar 23, 2017
Closed
jshimko added a commit to evereveofficial/reaction that referenced this pull request Mar 27, 2017
@jshimko
Merge branch 'development'
7fd332d 
* development:
  fix elasticsearch errors
  skip npm install outside of container on CI
  wait longer on CI for Docker test
  update CI config for Evereve
  add ReactionPublicCustomFolder
  update data_import
  update data_import
  update data_import
  add submodules to circle config
  add plugin submodules
  Don't reload when the main product is not in tbe modified products (reactioncommerce#2033)
  If default provider is not available, then add it. (reactioncommerce#2025)
  Dashboard panel keeps re-opening during checkout (reactioncommerce#2010)
  fixing issue 2008 getting 404 error on variant option (reactioncommerce#2021)
  Create "Tax Detail" view in Orders Dashboard (reactioncommerce#2005)
@aaronjudd aaronjudd mentioned this pull request Mar 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

@impactmass impactmass impactmass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zenweasel @mikemurray @impactmass