Release 1.2.0 #2258

aaronjudd · 2017-05-12T16:35:29Z

React Router React Router #2123 replaced flow-router and updated routing methods.
by @mikemurray
PDP Cleanup - React Basic Details Card, Tax Card & Inventory Card PDP Cleanup - Basic Details Card, Tax Card & Inventory Card #2086 by @kieha
Fix permissions for items shown in admin dashboard Fix permissions for items shown in admin dashboard #2145 by @impactmass
METEOR 1.4.4.2
Translation updates
Revision Control Option Images
2181 Revision Control Option Images #2236 by @abdulsemiu-atanda
Pin vsivsi:job-collection meteor package to 1.4.0 as a workaround to issue On a fresh windows 10 install reaction not started due to vsivsi:job-collection #2210
Pin vsivsi:job-collection meteor package to 1.4.0 as a workaround to issue #2210 #2228 by @hrath2015
Add Product Name To Invoice
2217 Add Product Name To Invoice #2226 by @abdulsemiu-atanda
Fix load order of shops/translations for Docker
Fix missing shop #2224 by @jshimko
Enhancement: Toggle Variant Visibility when Ancestor Product Visibility is Toggled
Toggle Variant Visibility when Ancestor Product Visibility is Toggled #2222 by @michael-alade
Enhancement: Create Product Should Flip into Edit Mode
2141 Create Product Should Flip into Edit Mode #2221 by @abdulsemiu-atanda
Fix Panel Expander Arrow Overlapping on Dropdown
1987 Panel Expander Arrow Overlapping on Dropdown #2211 by @abdulsemiu-atanda
Resolve Sent Email Closes Email Log Panel
Sent Email Closes Email Log Panel #2205 by @abdulsemiu-atanda
Added Kuwait, Saudi Arabia and Qatar currencies
Added Kuwait, Saudi Arabia and Qatar currencies #2204 by @lcampanis
Add OrderId To Checkout Completed Screen
Add OrderId To Checkout Completed Screen #2202 by @michael-alade
Completed Order Logged Out State
1638 Completed Order Logged Out State #2201, When logged out, cart completed shows "Order Processing" #1638 by @abdulsemiu-atanda
Fix Email Notification During Order Refund
Fix Email Notification During Order Refund #2200 by @michael-alade
made social share buttons on PDP ADA compliant
made social share buttons on PDP ADA compliant #2196 by @minimart
Add Reaction method for adding default roles
Add Reaction method for adding default roles #2174 by @spencern
Order Summary not showing the correct data
Order Summary not showing the correct data #2207 by @kieckhafer
Resolve Inconsistent Product Image of Cart Item
Inconsistent Product Image of Cart Items #2115 by @abdulsemiu-atanda
Performance, pagination updates for orders by @kieha
Product and inventory fixes by @joykare

…to development

… more' button

…to development

… more' button

…ctioncommerce/reaction into kieha-orders-pagination-1921

…ublish

* Initial test of filtering pkgs * Filter showing packages by permissions * Resolve issue with hasAccess check on registry items * Comment * Comment edit * Call packages coll without filter * Move audience addition to ReactionApps * Better comment * Check not needed again.Apps come based on access level * space fix * Test: Permissions on toolbar component * hasProduct access on toolbar * Fix data * Use createProduct as filter * Refactor toolbar permission check * Improve Comment * Add missing perms in pub * remove comment * Add comment on filter line

* Initial push for React Router conversion * Implement more global router functions - Added `Router.getQueryParam` - Added `Router.isActiveClassName` - Added shop prefix for routes - Added blaze event for brand link to use `Router.go` - Added `query-parse` nom module to parse query strings - Added route to currentRoute on route change * Route rendering - Router initialize - Rewrite reaction layout to better handle layout generation - Add `App` component as router base component - Add Router.replace function for push state replace * Move rest of router from client dir, into router package * Use Router.go for tagLink * Fixes issue with browserRouter router initializing before router core is ready. * Fixed route resolution for to exact matches * Updated dependencies and shrink-wrap * Not found and unauthorized routes and redirects * Rename admin template to coreLayout - use layout name to get proper layout * Fix broken import * Fix redirect url for PayPal pay flow express Double slash in url causes no route to be matched for react router. Added new helper method that wraps Meteor.absoluteUrl() and fetches the shop prefix without a leading slash. * Enable onEnter and legacy enter hooks * Added exit hooks and improved hook handling logic Re-implement metadata hook * Show package settings shortcuts only if requested * Added Router.watchPathChange() * Remove unused function * Added router go for grid item click event * Fix eslint issues * Added router go for cart items * Fix router context for hooks * Added special handling for print layout * Scrolling for content area as admin * Fix router reload when auth state changes * Fix lint issues * Fix lint issues * Fix blank pdf view * Prevent route change when previous and next routes match. -Remove reactivity from `Router.current()` to better align with flow router api. - Add reactive dependencies query and url param functions. * Fixed reference for getShopName() * Fixing broken blaze layout - Extend the react-in-blaze component, and rename conflicting `template` prop to `blazeTemplate` to avoid a naming collision with our layouts. - Added check for foundLayout, verify its defined before trying to access - Added support for blaze based layouts, if a react layout cannot be found * Removed unused packages * Adjust width of container to alleviate some scrolling issues * Higher zindex for cart slide out * Fix getSlug reference * Fixes issue with incorrectly displaying unauthorized template

* LingoHub Update 🚀 Manual push by LingoHub User: Aaron Judd. Project: reaction Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Aaron Judd. Project: reaction Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Aaron Judd. Project: reaction Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Aaron Judd. Project: reaction Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Brent Hoover. Project: reaction Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Brent Hoover. Project: reaction Made with ❤️ by https://lingohub.com * LingoHub Update 🚀 Manual push by LingoHub User: Brent Hoover. Project: reaction Made with ❤️ by https://lingohub.com

* add product name to invoice * add Product name to title

* wip * Use passed in audience for ReactionApps * Remove debug

Restore dropdown template helper method

* fix dropdown z-index * use z-index variable * reduce zindex-select variable value * override `react-select` select menu z-index * remove commented out style * fix improper variable value alignment * move import to main.less

Adds `reaction-paypal/paypalDone` and `reaction-paypal/paypalCancel` roles to the defaultRoles and defaultVisitorRoles set

zenweasel

A bunch of small nitpick/style things

zenweasel · 2017-05-15T07:33:15Z

README.md

-## Participation
-
-If you are interested in participating in the development of Reaction, that's really great!
+See our [Requirements Docs](https://docs.reactioncommerce.com/reaction-docs/master/requirements) for requirements that you may to install for Reaction.


I think this meant to say "you may need"?

zenweasel · 2017-05-15T07:36:15Z

README.md


-### What's Next
+We ensure that all releases are deployable as [Docker](https://www.docker.com/) containers.  While we don't regularly test other methods of deployment, our community has documented deployment strategies for [Heroku](https://github.com/reactioncommerce/reaction/issues/1363), AWS, [Digital Ocean](https://gist.github.com/jshimko/745ca66748846551692e24c267a56060), and Galaxy.


Do we want to remove this references to Heroku?

zenweasel · 2017-05-15T07:40:06Z

client/modules/router/main.js

-
-  Router.triggers.enter(Router.Hooks.get("onEnter", "GLOBAL"));
-  Router.triggers.exit(Router.Hooks.get("onExit", "GLOBAL"));
+  // Router.Hooks.onEnter(checkRouterPermissions);


Do we want to remove this commented code?

zenweasel · 2017-05-15T22:22:59Z

imports/plugins/core/checkout/client/templates/cartPanel/component/cartPanel.js

+          <span className="btn btn-success btn-lg btn-block" id="btn-checkout" data-i18n="cartDrawer.checkout"
+            onClick={this.props.onClick || this.props.checkout}
+          >
+            Checkout now


Do we need to change this to be <TranslationProvider>?

zenweasel · 2017-05-16T03:35:24Z

imports/plugins/core/checkout/client/components/cartSubTotal.js

+    if (Number(this.props.cartDiscount) > 0) {
+      return (
+        <tr>
+          <td data-i18n="cartSubTotals.discount">Discount</td>


@mikemurray Is the sort of use of data-i18n that we want to eliminate?

zenweasel · 2017-05-16T04:28:11Z

imports/plugins/included/product-variant/client/containers/variantFormContainer.js

+      }
+    });
+
+    if (provider) {


Could just return !!provider

We want to leave this how it is for better / easier code readability.

zenweasel · 2017-05-16T04:31:35Z

lib/api/helpers.js

@@ -1,7 +1,8 @@
 import url from "url";
 import { slugify } from "transliteration";
 import { Meteor } from "meteor/meteor";
-import { FlowRouter } from "meteor/kadira:flow-router-ssr";
+// import { FlowRouter } from "meteor/kadira:flow-router-ssr";


Weren't we going to remove this rather than comment it out?

zenweasel · 2017-05-16T05:25:41Z

server/api/core/addDefaultRoles.app-test.js

+import { Shops } from "/lib/collections";
+import { Reaction } from "/server/api";
+
+import { sinon } from "meteor/practicalmeteor:sinon";


Import order

zenweasel · 2017-05-16T05:35:02Z

server/methods/core/orders.app-test.js

+import { expect } from "meteor/practicalmeteor:chai";
+import { sinon } from "meteor/practicalmeteor:sinon";
+import Fixtures from "/server/imports/fixtures";
+// import { examplePaymentMethod } from "/server/imports/fixtures/packages";


Remove commented code

zenweasel · 2017-05-16T05:35:37Z

server/methods/core/orders.app-test.js

@@ -0,0 +1,502 @@
+import { Meteor } from "meteor/meteor";
+import { Factory } from "meteor/dburles:factory";
+import accounting from "accounting-js";


Import order

spencern

Approved - Lot's of issues, but not any regressions that I'm aware of.

Removed unused code

* update Router to adjust when shop URL is in provided data * update notification onClick to open dashboard panel when needed * re-add markOneAsRead

* update import of Reaction * readme updates * import fixes * add meteor import * import order fix * comment fixes * add meteor import * removed flow router import * import order * import fix * update i18n key * update translations * wrap full app in translation provider

aaronjudd · 2017-05-17T00:36:06Z

@mikemurray @kieckhafer @zenweasel is this ready -> seems to now have 3 pending reviews...

kieckhafer

👍

zenweasel · 2017-05-17T00:41:11Z

I'm still testing. I will approve as soon as I am done.

zenweasel

No blockers. Ship it.

impactmass and others added 30 commits March 1, 2017 22:05

Show Sidebar shipping in checkout

325adc9

Set actionView after payment checkout step

b9c4f47

Hide sidebar on entry to profile page

071dffa

Merge origin development

4700cd0

Merge branch 'development' of github.com:reactioncommerce/reaction in…

cb54270

…to development

Merge branch 'development' of github.com:reactioncommerce/reaction in…

4287301

…to development

Using publish-counts to record count of orders in order tabs

ce8fe91

Add alert and checkout message when item quantities have been adjusted

77e81c1

Code cleanup

4789f41

Add 'Show More' button for pagination (to be refined)

9fd8d60

Update errors to include when cart is already full

357d509

Removing unnecessary subscription.ready from composer function

07251f0

Modify orders cursor to use state instead; identify filter from 'show…

02d3028

… more' button

Actually deny when out of stock

8c840fc

Fix 'Show More' button functionality

f36c717

Add more descriptive error messages

07dc11b

Merge branch 'development' of github.com:reactioncommerce/reaction in…

51c1473

…to development

Merge branch 'development' into joykare-inventory-tracking-1928

4d797a7

Using publish-counts to record count of orders in order tabs

b411d7d

Code cleanup

090c1dd

Add 'Show More' button for pagination (to be refined)

d323449

Removing unnecessary subscription.ready from composer function

a30eb0e

Modify orders cursor to use state instead; identify filter from 'show…

08009a1

… more' button

Fix 'Show More' button functionality

b8d14a4

Merge branch 'kieha-orders-pagination-1921' of https://github.com/rea…

88d34e2

…ctioncommerce/reaction into kieha-orders-pagination-1921

Fix console error on Quantity

b1ca5b5

Fix PR arising issue on quantity

e4339cf

Using reactiveDict to store order limits

d20a93a

Using camelcase for naming

26ca6d9

Passing filter to PaginatedOrders subscription for query builder in p…

db6c5fc

…ublish

impactmass and others added 13 commits May 9, 2017 11:59

Pin vsivsi:job-collection meteor package to 1.4.0 (#2228)

e97a032

2217 Add Product Name To Invoice (#2226)

a731478

* add product name to invoice * add Product name to title

Permissions Fix: Use passed in "audience" param in ReactionApps (#2235)

f1306aa

* wip * Use passed in audience for ReactionApps * Remove debug

fix display of unpublished option images (#2236)

3529f9c

Restore helper to limit dropdown icons

a6cc84f

Merge pull request #2253 from reactioncommerce/revert-dropdowns-2252

e368543

Restore dropdown template helper method

1987 Panel Expander Arrow Overlapping on Dropdown (#2211)

4de6b06

* fix dropdown z-index * use z-index variable * reduce zindex-select variable value * override `react-select` select menu z-index * remove commented out style * fix improper variable value alignment * move import to main.less

Fixes #2243 Paypal Express requiring login for guest accounts (#2255)

b0b201c

Adds `reaction-paypal/paypalDone` and `reaction-paypal/paypalCancel` roles to the defaultRoles and defaultVisitorRoles set

Updated README.md

07e4962

Update version

45e524f

aaronjudd requested review from zenweasel and spencern May 12, 2017 20:28

aaronjudd changed the title ~~[WIP] Release 1.2.0~~ Release 1.2.0 May 12, 2017

zenweasel reviewed May 16, 2017

View reviewed changes

spencern approved these changes May 16, 2017

View reviewed changes

kieckhafer and others added 6 commits May 16, 2017 11:42

readme.md updates

749bd36

Removed unused code

638b525

Merge pull request #2282 from reactioncommerce/mikemurray-patch-1

cd598b4

Removed unused code

fix 2278 Router tables not initializing (#2279)

f4f7f61

fix notification dropdown links (#2280)

650679b

* update Router to adjust when shop URL is in provided data * update notification onClick to open dashboard panel when needed * re-add markOneAsRead

kieckhafer approved these changes May 17, 2017

View reviewed changes

zenweasel approved these changes May 17, 2017

View reviewed changes

aaronjudd merged commit d9ae98b into master May 17, 2017

aaronjudd deleted the release-1.2.0 branch August 23, 2017 22:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.2.0 #2258

Release 1.2.0 #2258

aaronjudd commented May 12, 2017 •

edited by abdulsemiu-atanda

zenweasel left a comment

zenweasel May 15, 2017

zenweasel May 15, 2017

zenweasel May 15, 2017

zenweasel May 15, 2017

zenweasel May 16, 2017

zenweasel May 16, 2017

kieckhafer May 16, 2017

zenweasel May 16, 2017

zenweasel May 16, 2017

zenweasel May 16, 2017

zenweasel May 16, 2017

spencern left a comment

aaronjudd commented May 17, 2017

kieckhafer left a comment

zenweasel commented May 17, 2017

zenweasel left a comment


		### What's Next
		We ensure that all releases are deployable as [Docker](https://www.docker.com/) containers. While we don't regularly test other methods of deployment, our community has documented deployment strategies for [Heroku](https://github.com/reactioncommerce/reaction/issues/1363), AWS, [Digital Ocean](https://gist.github.com/jshimko/745ca66748846551692e24c267a56060), and Galaxy.

Release 1.2.0 #2258

Release 1.2.0 #2258

Conversation

aaronjudd commented May 12, 2017 • edited by abdulsemiu-atanda

zenweasel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spencern left a comment

Choose a reason for hiding this comment

aaronjudd commented May 17, 2017

kieckhafer left a comment

Choose a reason for hiding this comment

zenweasel commented May 17, 2017

zenweasel left a comment

Choose a reason for hiding this comment

aaronjudd commented May 12, 2017 •

edited by abdulsemiu-atanda