Fix browsing by product tag #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foladipo
changed the title
zenweasel
reviewed
Sep 7, 2017
| @@ -114,6 +116,7 @@ const wrapComponent = (Comp) => ( | |||
| componentDidMount() { | |||
| window.addEventListener("resize", this.onWindowResize); | |||
| this.onWindowResize(); | |||
| this._isMounted = true; | |||
There was a problem hiding this comment.
What is prefacing this variable with an underscore supposed to indicate/accomplish?
There was a problem hiding this comment.
I prefixed that variable with an underscore to show that it's a custom implementation of the now deprecated ReactComponent.isMounted() as advised in this official React post.
There was a problem hiding this comment.
Furthermore, it's consistent with the _unmounted variable in imports/plugins/core/components/lib/composer/compose.js.
| @@ -259,11 +263,13 @@ const wrapComponent = (Comp) => ( | |||
| this.setState({ attachedBodyListener: false }); | |||
| } | |||
|
|
|||
| // TODO: If this is a method of TagNavContainer, why is it, and many | |||
| // others, declared as an arrow function? | |||
There was a problem hiding this comment.
I don't know if a TODO code comment is the best place to get a programming question answered.
zenweasel
requested changes
Sep 7, 2017
|
This works and I would like to merge it but I don't know what's up with the underscored variables |
zenweasel
approved these changes
Sep 7, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2626.
This PR fixes a bug in the
marketplacebranch. The cause was that this app was executing a certain callback that doessetStatein a React component that had been unmounted. This caused an error to be thrown in the browser console.Test instructions
localhost:3000.localhost:3000/tags/SUB_TAGand click outside the navbar.