Fix console errors after placing an order for a single shop in multi-shop mode

[kieha]

Resolves #3024

How to test

• Create a marketplace shop and create a product for that shop
• In admin shop, place only that product in the cart and checkout
• Observe no server errors

[spencern]

@kieha this does fix the console errors, but it introduces some issues in the email that gets sent to the customer, so my guess is that you've solved some symptoms rather than the core problem here.

[zenweasel]

I think this is a complicated problem that I am not immediately sure what the solution is, because when we had only one payment we knew what to look for but when we have multiple shops we can't just use getShopId because the current shop might not be the shop that the charge was against. Theoretically we should be passing in paymentMethod to this like we do with orders/refunds/create and then grabbing the information based on that rather than just assuming we can get the payment method by current shop.

[zenweasel]

Looking at the code this gets called a couple of times in two different contexts. In the context of the user it should cycle through all payments and return an array of refunds for all shops because a user doesn't care which shop, just wants the total (and that's what's throwing the error). The code is already expecting an array of refunds.

Working out how it will work in the order dashboard might be something we could figure out post-alpha release.

I do think we need to back out some of this code where we are failing silently.

[zenweasel]

Ok, last thought. If we use the order passed in only (don't re-grab it from the DB), which should be filtered already, then we should just be able to always query for all the billing records on the order and return an array because orders from dashboard should already be filtered so that should fix both situations I think.

[zenweasel]

Rather than modify @kieha's PR I opened a new PR with an alternative fix here: #3064

[kieha]

Closing this in favor of #3064