Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing product grid images #3157

Merged

Conversation

codejockie
Copy link
Contributor

Resolves #3137

This PR fixes the issue on images with spaces in filename not showing up on the product grid page.

Test

  1. Login as admin
  2. Add product and create product variant
  3. Upload image from filename with one or more spaces in it & publish
  4. See that it shows on PDP page
  5. Go to product grid and see that it shows

Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed.

@zenweasel zenweasel changed the base branch from master to release-1.5.6 November 2, 2017 21:47
@zenweasel zenweasel merged commit b943a72 into release-1.5.6 Nov 2, 2017
@zenweasel zenweasel deleted the kennedy-fix-missing-product-grid-images-3137 branch November 2, 2017 21:48
@zenweasel zenweasel mentioned this pull request Nov 2, 2017
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
…oduct-grid-images-3137

Fix missing product grid images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants