Fix issue #3179: React.PropTypes is deprecated #3180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n console Signed-off-by: José Luis Di Biase <josx@interorganic.com.ar>
|
@mikemurray any reason we shouldn't merge this? |
|
There was a reason I didn't change this when I converted these over. May have something to do with translations? Let's just make sure and test before we merge. |
|
Gave this a quick once-over and not seeing any problems so 😅 |
|
@mikemurray can you give this a review soon? |
mikemurray
approved these changes
Nov 9, 2017
This was referenced Nov 9, 2017
Merged
Akarshit
pushed a commit
that referenced
this pull request
Jan 7, 2018
Fix issue #3179: React.PropTypes is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #3179
All RC code havent to use React.PropTypes becase are deprecated, If not Will no work on React >= 16
Check https://reactjs.org/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes