doc: namespace server methods into Core #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machikoyasuda
force-pushed
the
jsdoc-namespace-server-core
branch
from
9273a7e
to
b98e72b
Compare
added 14 commits
November 9, 2017 15:31
machikoyasuda
force-pushed
the
jsdoc-namespace-server-core
branch
from
6aeb503
to
d9708d2
Compare
machikoyasuda
changed the title
spencern
approved these changes
Dec 18, 2017
There was a problem hiding this comment.
Looks good to me.
@machikoyasuda We need to update docs.reactioncommerce.com with some examples like this that show exactly which fields should be included, and in what order. Probably also need to have a section that explains when to use @memberof and @namespace
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what this pr does
CatalogEmailEndpointsCorewhat that does
and everything else is in
CoreCore has methods from /lib/ and /server/api/core. Might want to separate those in the future, but going to keep it in Core for now.