Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Failed to get currency exchange rates" error in server #3218

Merged
merged 2 commits into from Nov 9, 2017
Merged

Fix "Failed to get currency exchange rates" error in server #3218

merged 2 commits into from Nov 9, 2017

Conversation

codejockie
Copy link
Contributor

@codejockie codejockie commented Nov 1, 2017 •
edited

Resolves #3103

This PR fixes the error logged on the server when the open exchange appId is not set. It ensures that the error message doesn't show up if appId isn't set.

Test

  1. Unset the Open Exchange API App ID by removing it from the reaction.json file
  2. Do a reaction reset of the app
  3. Run app after reset
  4. Visit the home route http://localhost:3000
  5. Check that on the terminal, you no longer see the error message "Failed to get currency exchange rates."

@codejockie codejockie changed the title fix "Failed to get currency exchange rates" error in server if the Op… Fix "Failed to get currency exchange rates" error in server Nov 1, 2017
@codejockie codejockie mentioned this pull request Nov 1, 2017
Closed
zenweasel
zenweasel approved these changes Nov 8, 2017
View reviewed changes
Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed.

@spencern spencern changed the base branch from master to release-1.5.7 November 9, 2017 00:57
@spencern
Copy link
Contributor

spencern commented Nov 9, 2017

eslint passes locally

@spencern spencern merged commit 426e5f1 into release-1.5.7 Nov 9, 2017
@spencern spencern deleted the kennedy-fix-failed-to-get-currency-exchange-rates-error-3103 branch November 9, 2017 01:24
@spencern spencern mentioned this pull request Nov 9, 2017
Merged
Akarshit pushed a commit that referenced this pull request Jan 7, 2018
@spencern
Merge pull request #3218 from reactioncommerce/kennedy-fix-failed-to-…
bb57bd6 
…get-currency-exchange-rates-error-3103

Fix "Failed to get currency exchange rates" error in server
@snyk-bot snyk-bot mentioned this pull request May 26, 2022
Open
@saurabharch saurabharch mentioned this pull request May 28, 2022
Open
This was referenced Jun 20, 2022
Open
Open
@csnyk csnyk mentioned this pull request Jul 20, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 18, 2022
Open
@zenweasel zenweasel mentioned this pull request Sep 26, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@csnyk csnyk mentioned this pull request Oct 7, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenweasel zenweasel zenweasel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codejockie @spencern @zenweasel