Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Not being able to scroll after using search function #3314 #3315

Merged

Conversation

wackywombaat12
Copy link
Contributor

This is a fix for issue #3314.

Fix

You can now scroll as normal after searching for a product or exiting the search function. This involved removing the the 'overflow: hidden' style tag from the body HTML element after a search is complete.

Test

  1. Click on the search icon
  2. Search for a product
  3. Click on the product
  4. Observe that you can now scroll as intended on the page.

Copy link

@samyilias samyilias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works :)

@zenweasel
Copy link
Collaborator

@wackywombaat12 @samyilias I am not able to replicate the original error this is supposed to fix. Please see my notes on the ticket.

@zenweasel zenweasel removed the blocked label Dec 4, 2017
Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed.

@spencern spencern changed the base branch from master to release-1.7.0 December 13, 2017 21:38
@spencern spencern merged commit 4b74b2d into reactioncommerce:release-1.7.0 Dec 13, 2017
This was referenced Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants