Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site will open in a new tab #3327

Merged
merged 4 commits into from
Dec 13, 2017
Merged

Site will open in a new tab #3327

merged 4 commits into from
Dec 13, 2017

Conversation

Akarshit
Copy link
Contributor

Fix for #3320

To check

  1. Run reaction.
  2. Open the tax menu from left sidebar.
  3. Click on Avalara Admin Console Login, observe the site opening in new tab.

@Akarshit Akarshit mentioned this pull request Nov 23, 2017
Closed
@zenweasel zenweasel self-requested a review November 29, 2017 00:33
zenweasel
zenweasel approved these changes Nov 30, 2017
View reviewed changes
Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed

@spencern spencern changed the base branch from master to release-1.7.0 December 13, 2017 23:41
@spencern spencern merged commit 86e98ea into reactioncommerce:release-1.7.0 Dec 13, 2017
This was referenced Dec 14, 2017
Closed
Merged
@Akarshit Akarshit deleted the bugfix-siteNewTab branch February 23, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenweasel zenweasel zenweasel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Akarshit @zenweasel @spencern