Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update product screenshot to reflect new version #3362

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

sophiehe
Copy link
Contributor

Please provide the following information to help us approve your PR. Failure to provide this
information may result in your PR being closed without comment.

  • Clearly explain what your PR is trying to accomplish. A link to an issue is best
  • Provide us detailed instructions on how we can test your PR

@@ -63,7 +63,7 @@ Learn more on how to [configure your project](https://docs.reactioncommerce.com/
- [Reaction Commerce YouTube videos](https://www.youtube.com/user/reactioncommerce/videos)

## Join the community calls
- [Reaction Community calls](http://getrxn.io/2rcCal): Join our biweekly community calls every other Wednesday at 7AM PST/10AM EST.
- [Reaction community calls](http://getrxn.io/2rcCal): Join our biweekly community calls every other Wednesday at 7AM PST/10AM EST.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change this to reflect the rotating schedule of 7/9 am?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophiehe @zenweasel who's making this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be the PR creator? @sophiehe? Or we can just not do it at 9am any more/ever which I am also in favor of.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7AM PST/10AM EST/3PM GMT

README.md Outdated
@@ -4,7 +4,7 @@

[Reaction](http://reactioncommerce.com) is an event-driven, real-time reactive commerce platform built with JavaScript (ES6). It plays nicely with npm, Docker, and React.

![Reaction v.1.0.0](https://raw.githubusercontent.com/reactioncommerce/reaction-docs/master/assets/rc-desktop.png)
![Reaction v.1.0.0](https://raw.githubusercontent.com/reactioncommerce/reaction-docs/master/assets/Reaction-Commerce-Illustration-BG-800px.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the version # as well?

aaronjudd
aaronjudd previously approved these changes Dec 4, 2017
Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't doing the 9am call any more per @machikoyasuda so lgtm

@sophiehe
Copy link
Contributor Author

@spencern this PR looks good to go. let's get it merged for the next release

@spencern spencern changed the base branch from master to release-1.6.2 December 18, 2017 19:37
@spencern spencern merged commit 51b8ac5 into release-1.6.2 Dec 18, 2017
@spencern spencern mentioned this pull request Dec 18, 2017
@zenweasel zenweasel deleted the sophiehe-readme-edit branch December 19, 2017 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants