Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(constants): #3409 document default variables #3413

Merged
merged 2 commits into from
Dec 18, 2017
Merged

docs(constants): #3409 document default variables #3413

merged 2 commits into from
Dec 18, 2017

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Dec 15, 2017 •
edited

closes #3409

what this pr does

  • document variables from default.js and constants.js
  • link to docs on how to override those settings
  • link to docs on how to create a Layout

screen shot 2017-12-15 at 2 14 07 pm
screen shot 2017-12-15 at 2 15 13 pm

how to test it

  1. pull this branch
  2. run npm run docs
  3. open file:///tmp/reaction-docs/Constants.html

docs(constants): namespace Constants, document application global con…
2aaf4d0 
…stant variables for changing layouts, workflows. add link to docs on layouts.
@machikoyasuda machikoyasuda force-pushed the docs-3409-machikoyasuda-constants branch from bc3b224 to 2aaf4d0 Compare December 15, 2017 22:11
spencern
spencern approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spencern spencern changed the base branch from master to release-1.6.2 December 18, 2017 21:07
@spencern spencern merged commit c6652ce into release-1.6.2 Dec 18, 2017
@spencern spencern deleted the docs-3409-machikoyasuda-constants branch December 18, 2017 21:08
@spencern spencern mentioned this pull request Dec 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencern spencern spencern approved these changes

@prinzdezibel prinzdezibel Awaiting requested review from prinzdezibel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@machikoyasuda @spencern