Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ‘order’ should be translated to '订单' rather than ‘命令’ in Chinese #3428

Merged
merged 1 commit into from Jan 8, 2018

Conversation

unaheidi
Copy link
Contributor

In Chinese, we use "订单" to express ’order for goods‘ rather than ’命令‘.
And when Chinese people use ’命令‘, we want to express ‘command’ .
So I suggest that 'order' in ecommerce should be translated to "订单" in Chinese.

@zenweasel zenweasel self-requested a review January 4, 2018 23:07
@zenweasel
Copy link
Collaborator

@unaheidi Thanks for so much for the contribution! Please make sure and enter our hack-a-bug-a-thon here for a chance to win gift cards or swag.

Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We might want to look at replacing other usages but we can do that in a separate ticket.

@spencern spencern changed the base branch from master to release-1.6.4 January 8, 2018 16:40
@spencern spencern merged commit 3189ca4 into reactioncommerce:release-1.6.4 Jan 8, 2018
@spencern spencern mentioned this pull request Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants