fix #3474 making validatedAddress object to prevent exception #3504
Conversation
server/methods/accounts/accounts.js
Outdated
| validatedAddress.failedValidation = false; | ||
| validatedAddress = { | ||
| failedValidation: false | ||
| }; | ||
| } | ||
| } | ||
| const validationResults = { validated, fieldErrors: validationErrors, formErrors, validatedAddress }; |
There was a problem hiding this comment.
previously, this method returned the address passed to it, but with your change, it could be replaced with { failedValidation: false }. This could be fine (I have no idea what the downstream code looks like), but feels like a potentially breaking change.
To be safe, consider checking that validatedAddress is null/undefined,
// line 294:
if (!validatedAddress) {
validatedAddress = {};
}
validatedAddress.failedValidation = false; // same as it was
There was a problem hiding this comment.
@pmn4 Isn't validatedAddress already being checked at line 285? This snippet is in the else clause of that check.
There was a problem hiding this comment.
oops! my bad. I thought this was the else for if (validator)
|
I know this isn't exactly in the scope of this bug, but it would seem to me like both places where |
server/methods/accounts/accounts.js
Outdated
| validatedAddress.failedValidation = false; | ||
| validatedAddress = { | ||
| failedValidation: false | ||
| }; | ||
| } | ||
| } | ||
| const validationResults = { validated, fieldErrors: validationErrors, formErrors, validatedAddress }; |
There was a problem hiding this comment.
@pmn4 Isn't validatedAddress already being checked at line 285? This snippet is in the else clause of that check.
Fix for #3474
To test
reactionExample Productand go to the checkout sceen.Save and Continue.