Add eslint rules #3556
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,76 +1,80 @@ | ||
| { | ||
| "parser": "babel-eslint", | ||
| // "extends": [ | ||
| // "plugin:jsx-a11y/recommended" | ||
| // ], | ||
| "env": { | ||
| "browser": true, | ||
| "es6": true, | ||
| "jest/globals": true, | ||
| "mocha": true, | ||
| "node": true | ||
| }, | ||
| "globals": { | ||
| "Assets": true, // Meteor global | ||
| "Package": true, // Meteor global | ||
| "FS": true, // gridFS, | ||
| "Alerts": true // this needs to get cleaned up, but ignoring for now | ||
| }, | ||
| "settings": { | ||
| "import/resolver": "meteor" | ||
| }, | ||
| "parserOptions": { | ||
| "ecmaVersion": 2017, | ||
|
There was a problem hiding this comment. Diff looks weird here, but the only actual change to |
||
| "sourceType": "module", | ||
| "ecmaFeatures": { | ||
| "arrowFunctions": true, | ||
| "blockBindings": true, | ||
| "classes": true, | ||
| "defaultParams": true, | ||
| "destructuring": true, | ||
| "forOf": true, | ||
| "generators": false, | ||
| "modules": true, | ||
| "objectLiteralComputedProperties": true, | ||
| "objectLiteralDuplicateProperties": false, | ||
| "objectLiteralShorthandMethods": true, | ||
| "objectLiteralShorthandProperties": true, | ||
| "spread": true, | ||
| "superInFunctions": true, | ||
| "templateStrings": true, | ||
| "jsx": true | ||
| }, | ||
| "allowImportExportEverywhere": true | ||
| }, | ||
| "plugins": ["import", "jest", "jsx-a11y", "react"], | ||
| "rules": { | ||
| /** | ||
| * Strict mode | ||
| * babel inserts "use strict"; for us | ||
| * http://eslint.org/docs/rules/strict | ||
| */ | ||
| "strict": 0, | ||
|
|
||
| /** | ||
| * ES6 | ||
| */ | ||
| "object-curly-spacing": ["error", "always", { "objectsInObjects": true }], | ||
| "no-var": 2, // http://eslint.org/docs/rules/no-var | ||
|
|
||
| /** | ||
| * Variables | ||
| */ | ||
| "no-shadow": 2, // http://eslint.org/docs/rules/no-shadow | ||
| "no-shadow-restricted-names": 2, // http://eslint.org/docs/rules/no-shadow-restricted-names | ||
| "no-const-assign": 2, // http://eslint.org/docs/rules/no-const-assign | ||
| "no-unused-vars": [2, { // http://eslint.org/docs/rules/no-unused-vars | ||
| "vars": "all", | ||
| "args": "after-used", | ||
| "ignoreRestSiblings": true | ||
| }], | ||
| "no-use-before-define": [2, "nofunc"], // http://eslint.org/docs/rules/no-use-before-define | ||
| "no-implicit-globals": 2, // http://eslint.org/docs/rules/no-implicit-globals | ||
|
|
||
| /** | ||
| * Possible errors | ||
| */ | ||
| "comma-dangle": ["error", "never"], // http://eslint.org/docs/rules/comma-dangle | ||
| "no-cond-assign": [2, "always"], // http://eslint.org/docs/rules/no-cond-assign | ||
| "no-console": 2, // http://eslint.org/docs/rules/no-console | ||
| "no-debugger": 1, // http://eslint.org/docs/rules/no-debugger | ||
|
|
@@ -80,7 +84,7 @@ | |
| "no-duplicate-case": 2, // http://eslint.org/docs/rules/no-duplicate-case | ||
| "no-empty": 2, // http://eslint.org/docs/rules/no-empty | ||
| "no-ex-assign": 2, // http://eslint.org/docs/rules/no-ex-assign | ||
| "no-extra-boolean-cast": 2, // http://eslint.org/docs/rules/no-extra-boolean-cast | ||
|
There was a problem hiding this comment. 👍 for this one |
||
| "no-extra-semi": 2, // http://eslint.org/docs/rules/no-extra-semi | ||
| "no-func-assign": 2, // http://eslint.org/docs/rules/no-func-assign | ||
| "no-inner-declarations": 2, // http://eslint.org/docs/rules/no-inner-declarations | ||
|
|
@@ -93,8 +97,8 @@ | |
| "block-scoped-var": 0, // http://eslint.org/docs/rules/block-scoped-var | ||
|
|
||
| /** | ||
| * JSX / React | ||
| */ | ||
| "jsx-quotes": [2, "prefer-double"], // http://eslint.org/docs/rules/jsx-quotes | ||
| "react/no-deprecated": 1, | ||
| "react/display-name": 1, | ||
|
|
@@ -129,8 +133,8 @@ | |
| "react/sort-comp": 1, | ||
|
|
||
| /** | ||
| * Best practices | ||
| */ | ||
| "consistent-return": [0, { // http://eslint.org/docs/rules/consistent-return | ||
| "treatUndefinedAsUnspecified": true | ||
| }], | ||
|
|
@@ -166,7 +170,7 @@ | |
| "no-param-reassign": 2, // http://eslint.org/docs/rules/no-param-reassign | ||
| "no-proto": 2, // http://eslint.org/docs/rules/no-proto | ||
| "no-redeclare": 2, // http://eslint.org/docs/rules/no-redeclare | ||
| "no-return-assign": ["error", "always"], // http://eslint.org/docs/rules/no-return-assign | ||
| "no-script-url": 2, // http://eslint.org/docs/rules/no-script-url | ||
| "no-self-compare": 2, // http://eslint.org/docs/rules/no-self-compare | ||
| "no-sequences": 2, // http://eslint.org/docs/rules/no-sequences | ||
|
|
@@ -175,7 +179,7 @@ | |
| "no-undef": 2, | ||
| "radix": 2, // http://eslint.org/docs/rules/radix | ||
| "vars-on-top": 2, // http://eslint.org/docs/rules/vars-on-top | ||
| "wrap-iife": ["error", "outside", { "functionPrototypeMethods": false }], // http://eslint.org/docs/rules/wrap-iife | ||
| "yoda": 2, // http://eslint.org/docs/rules/yoda | ||
| "max-len": [1, 160, 2, { | ||
| "ignoreComments": true, | ||
|
|
@@ -196,18 +200,17 @@ | |
| } | ||
| }], // http://eslint.org/docs/rules/valid-jsdoc | ||
| "quote-props": [2, "consistent-as-needed"], // http://eslint.org/docs/rules/quote-props | ||
|
|
||
| /** | ||
| * Style | ||
| */ | ||
| "indent": [2, 2, {"SwitchCase": 1}], // http://eslint.org/docs/rules/indent | ||
| "brace-style": [2, // http://eslint.org/docs/rules/brace-style | ||
| "1tbs", { | ||
| "allowSingleLine": true | ||
| } | ||
| ], | ||
| "quotes": ["error", "double", { "avoidEscape": true }], // http://eslint.org/docs/rules/quotes | ||
| "camelcase": [2, { // http://eslint.org/docs/rules/camelcase | ||
| "properties": "always" | ||
| }], | ||
|
|
@@ -253,6 +256,91 @@ | |
| "space-infix-ops": 2, // http://eslint.org/docs/rules/space-infix-ops | ||
| "space-in-parens": [2, "never"], // http://eslint.org/docs/rules/space-in-parens | ||
| "spaced-comment": [2, "always"], // http://eslint.org/docs/rules/spaced-comment | ||
| "arrow-spacing": [2, { "before": true, "after": true }], // https://eslint.org/docs/rules/arrow-spacing | ||
|
|
||
| /** | ||
| * Additional rules to enable one by one | ||
| */ | ||
| // "array-bracket-spacing": ["error", "never"], | ||
| // "array-callback-return": ["error", { "allowImplicit": true }], | ||
|
There was a problem hiding this comment. this should be super helpful. 👍 |
||
| // "arrow-body-style": ["error", "as-needed", { "requireReturnForObjectLiteral": false }], | ||
| // "arrow-parens": [ "error", "always", { "requireForBlockBody": true }], | ||
| // "block-spacing": ["error", "always"], | ||
| // "computed-property-spacing": ["error", "never"], | ||
| // "dot-location": ["error", "property"], | ||
| // "function-paren-newline": ["error", "multiline"], | ||
| // "import/export": "error", | ||
|
There was a problem hiding this comment. @aldeed Do these There was a problem hiding this comment. Yes. The plugin packages all begin with I pulled in the rules Airbnb uses for I added the |
||
| // "import/first": ["error", "absolute-first"], | ||
|
There was a problem hiding this comment. How will this play with dynamic imports? There was a problem hiding this comment. Per the docs, it only looks at |
||
| // "import/newline-after-import": "error", | ||
| // "import/no-duplicates": "error", | ||
| // "import/no-mutable-exports": "error", | ||
| // "import/no-named-default": "error", | ||
| // "new-parens": "error", | ||
| // "newline-per-chained-call": ["error", { "ignoreChainWithDepth": 4 }], | ||
|
There was a problem hiding this comment. Just copied this one from Airbnb, so I'm ok with any number we agree on |
||
| // "no-await-in-loop": "error", | ||
| // "no-bitwise": "error", | ||
| // "no-case-declarations": "error", | ||
| // "no-confusing-arrow": ["error", { "allowParens": true }], | ||
| // "no-empty-pattern": "error", | ||
| // "no-lonely-if": "error", | ||
| // // This rule copied from Airbnb's config | ||
| // "no-mixed-operators": ["error", { | ||
|
|
||
| // "groups": [ | ||
| // ["%", "**"], | ||
| // ["%", "+"], | ||
| // ["%", "-"], | ||
| // ["%", "*"], | ||
| // ["%", "/"], | ||
| // ["**", "+"], | ||
| // ["**", "-"], | ||
| // ["**", "*"], | ||
| // ["**", "/"], | ||
| // ["&", "|", "^", "~", "<<", ">>", ">>>"], | ||
| // ["==", "!=", "===", "!==", ">", ">=", "<", "<="], | ||
| // ["&&", "||"], | ||
| // ["in", "instanceof"] | ||
| // ], | ||
| // "allowSamePrecedence": false | ||
| // }], | ||
| // "no-multi-assign": ["error"], | ||
| // "no-multi-spaces": ["error", { "ignoreEOLComments": false }], | ||
| // "no-plusplus": "error", | ||
|
|
||
| // "no-prototype-builtins": "error", | ||
| // "no-tabs": "error", | ||
| // "no-undef-init": "error", | ||
| // "no-unneeded-ternary": ["error", { "defaultAssignment": false }], | ||
| // "no-unsafe-finally": "error", | ||
| // "no-useless-computed-key": "error", | ||
| // "no-useless-concat": "error", | ||
| // "no-useless-constructor": "error", | ||
| // "no-useless-escape": "error", | ||
| // "no-void": "error", | ||
| // "object-curly-newline": ["error", { "ObjectExpression": { "multiline": true, "consistent": true }, "ObjectPattern": { "multiline": true, "consistent": true } }], | ||
| // "object-property-newline": ["error", { "allowAllPropertiesOnSameLine": true }], | ||
| // "object-shorthand": ["error", "always"], | ||
| // "operator-assignment": ["error", "always"], | ||
| // "prefer-arrow-callback": ["error", { "allowNamedFunctions": false, "allowUnboundThis": true }], | ||
| // "prefer-destructuring": ["error", { | ||
| // "VariableDeclarator": { | ||
| // "array": false, | ||
| // "object": true | ||
| // }, | ||
| // "AssignmentExpression": { | ||
| // "array": true, | ||
| // "object": true | ||
| // } | ||
| // }, { | ||
| // "enforceForRenamedProperties": false | ||
| // }], | ||
| // "prefer-rest-params": "error", | ||
| // "prefer-spread": "error", | ||
| // "prefer-template": "error", | ||
| // "rest-spread-spacing": ["error", "never"], | ||
| // "space-unary-ops": ["error", { | ||
| // "words": true, | ||
| // "nonwords": false, | ||
| // "overrides": {} | ||
| // }], | ||
| // "template-curly-spacing": "error" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pulls in default accessibility recommendations for React components, which I think is a requirement for Reaction, right? This, like the rules, can be uncommented in a later ticket. There are ~100 errors from it, and they'll take manual work to solve.