Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable eslint space-unary-ops #3588

Merged
merged 1 commit into from Jan 26, 2018

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Jan 25, 2018

Part of #3573

Enables eslint's space-unary-ops, and fixes the lint issues in a few files.

Changes:

  • a ++ becomes a++.
  • typeof(Boolean(a)) becomes typeof (Boolean(a))

This shouldn't cause any breaking change.

@impactmass impactmass changed the title [WIP] feat: Enable eslint space-unary-ops feat: Enable eslint space-unary-ops Jan 25, 2018
@impactmass impactmass requested review from kieckhafer and willopez and removed request for kieckhafer January 25, 2018 18:00
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@spencern spencern changed the base branch from master to release-1.7.0 January 26, 2018 18:44
@spencern spencern merged commit 4f52668 into release-1.7.0 Jan 26, 2018
@spencern spencern deleted the feat-3573-fix-eslint-space-unary-ops branch January 26, 2018 18:45
@spencern spencern mentioned this pull request Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants