Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3815 Don't use default for moment in invoice #3816

Merged
merged 1 commit into from Feb 22, 2018

Conversation

zenweasel
Copy link
Collaborator

Resolves #3815
Impact: critical
Type: bugfix

Issue

moment was coming up undefined because we were looking for moment.default

Solution

Just use the root moment object returned by the import

Breaking changes

None

Testing

  1. Add a product to cart and complete an order
  2. Approve and Capture the order
  3. Click on "Print Invoice"
  4. Observe that the date is shown and there is no error in the console

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Resolved the client errors and correctly displays the date on the invoice.

image

@spencern spencern merged commit 86530ec into release-1.8.0 Feb 22, 2018
@spencern spencern deleted the fix-3815-brent-date-in-invoice branch February 22, 2018 01:13
@spencern spencern mentioned this pull request Feb 22, 2018
@spencern spencern mentioned this pull request Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants