Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3815 Don't use `default` for moment in invoice #3816

Merged
merged 1 commit into from Feb 22, 2018

Conversation

3 participants
@zenweasel
Copy link
Member

commented Feb 22, 2018

Resolves #3815
Impact: critical
Type: bugfix

Issue

moment was coming up undefined because we were looking for moment.default

Solution

Just use the root moment object returned by the import

Breaking changes

None

Testing

  1. Add a product to cart and complete an order
  2. Approve and Capture the order
  3. Click on "Print Invoice"
  4. Observe that the date is shown and there is no error in the console
@spencern
Copy link
Member

left a comment

👍 Resolved the client errors and correctly displays the date on the invoice.

image

@spencern spencern merged commit 86530ec into release-1.8.0 Feb 22, 2018

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
WIP ready for review
Details
ci/circleci Your tests passed on CircleCI!
Details
security/snyk No new issues
Details

@spencern spencern deleted the fix-3815-brent-date-in-invoice branch Feb 22, 2018

@spencern spencern referenced this pull request Feb 22, 2018

Merged

Release 1.8.0 #3645

@spencern spencern referenced this pull request Mar 9, 2018

Merged

Release 1.9.0 #3941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.