Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: hooks in the inventory package to use Hooks.Events #3887

Merged
merged 52 commits into from Mar 20, 2018
Merged

refactor: hooks in the inventory package to use Hooks.Events #3887

merged 52 commits into from Mar 20, 2018

Commits on Mar 2, 2018

  1. ref: convert Products.after.remove to Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    c4d3b1b View commit details
    Browse the repository at this point in the history

  2. ref: add hook

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    b9cd5f8 View commit details
    Browse the repository at this point in the history

  3. docs: add jsdoc to afterRemoveCatalogProduct hook

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    df0d852 View commit details
    Browse the repository at this point in the history

  4. ref: add afterInsertCatalogProduct Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    75ecf12 View commit details
    Browse the repository at this point in the history

  5. ref: convert Products.after.insert to Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    044af72 View commit details
    Browse the repository at this point in the history

  6. docs: add jsdoc to existing Hooks

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    df54968 View commit details
    Browse the repository at this point in the history

  7. ref: add afterInsertCatalogProduct hook

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    812f39d View commit details
    Browse the repository at this point in the history

  8. ref: convert Products.after.remove to Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    b341e61 View commit details
    Browse the repository at this point in the history

  9. ref: add hook

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    9dd0451 View commit details
    Browse the repository at this point in the history

  10. docs: add jsdoc to afterRemoveCatalogProduct hook

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    3325e62 View commit details
    Browse the repository at this point in the history

  11. ref: add afterInsertCatalogProduct Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    11b7090 View commit details
    Browse the repository at this point in the history

  12. ref: add afterInsertCatalogProduct Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    b47d4cd View commit details
    Browse the repository at this point in the history

  13. ref: add afterInsertCatalogProduct Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    41e2b62 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. docs: jsdoc for existing functions

    @kieckhafer
    kieckhafer committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    ab65bc5 View commit details
    Browse the repository at this point in the history

  2. ref: change Orders.after.insert to Hooks.Events

    @kieckhafer
    kieckhafer committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    e7baccd View commit details
    Browse the repository at this point in the history

  3. ref: change Orders.after.update to Hooks.event

    @kieckhafer
    kieckhafer committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    6b78a02 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ref-3865-kieckhafer-inventoryCollectionHooks

    @kieckhafer
    kieckhafer committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    589cb97 View commit details
    Browse the repository at this point in the history

  5. Merge branch '3634-willopez-remove-product-collection-hooks' into ref… 

    …-3865-kieckhafer-inventoryCollectionHooks
    @kieckhafer
    kieckhafer committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    0c0cdf5 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Merge branch '3634-willopez-remove-product-collection-hooks' into ref… 

    …-3865-kieckhafer-inventoryCollectionHooks
    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    13a515a View commit details
    Browse the repository at this point in the history

  2. ref: remove uneeded Meteor.userId from Hooks

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    0b8c534 View commit details
    Browse the repository at this point in the history

  3. ref: remove unneeded userId from Hook

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    ab32039 View commit details
    Browse the repository at this point in the history

  4. ref: return order document in hook

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    a7d34bc View commit details
    Browse the repository at this point in the history

  5. fix: typo

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    a0f37db View commit details
    Browse the repository at this point in the history

  6. ref: return order document for later use in other hooks

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    7bd712c View commit details
    Browse the repository at this point in the history

  7. ref: add Hooks.Events.run("afterUpdateCatalogProduct") on order approval

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    c6a920c View commit details
    Browse the repository at this point in the history

  8. ref: add Hooks.Events.run("afterUpdateCatalogProduct") on order approval

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    e34c2cb View commit details
    Browse the repository at this point in the history

  9. ref: add Hooks.Events.run("afterUpdateCatalogProduct") on order cance… 

    …l and restock
    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    6ebfb68 View commit details
    Browse the repository at this point in the history

  10. docs: add @method names

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    53ce726 View commit details
    Browse the repository at this point in the history

  11. ref: change Producs.after.update to Hooks.Events.add("afterUPdateCata… 

    …logProduct")
    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    0a24f73 View commit details
    Browse the repository at this point in the history

  12. ref: add inventory Hooks.Events to shopify import

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    0d59aa7 View commit details
    Browse the repository at this point in the history

  13. ref: add inventory hook to flushQuantity

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    af2ea53 View commit details
    Browse the repository at this point in the history

  14. fix: lint fixes

    @kieckhafer
    kieckhafer committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    fb1c9b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. Merge branch 'release-1.10.0' into ref-3865-kieckhafer-inventoryColle… 

    …ctionHooks
    @kieckhafer
    kieckhafer committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    24f3016 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/release-1.10.0' into ref-3865-ki… 

    …eckhafer-inventoryCollectionHooks
    @mikemurray
    mikemurray committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    edc0537 View commit details
    Browse the repository at this point in the history

  3. Fix failing tests

    @willopez
    willopez committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    7d78f9b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'ref-3865-kieckhafer-inventoryCollectionHooks' of https:… 

    …//github.com/reactioncommerce/reaction into ref-3865-kieckhafer-inventoryCollectionHooks
    @willopez
    willopez committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    f54d324 View commit details
    Browse the repository at this point in the history

  5. refactor: remove extra spaces

    @mikemurray
    mikemurray committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    9621918 View commit details
    Browse the repository at this point in the history

  6. refactor: remove unused variable

    @mikemurray
    mikemurray committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    a746198 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Remove unnecessary hook execution

    @willopez
    willopez committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    3f862a4 View commit details
    Browse the repository at this point in the history

  2. Don't run search mongo hook if conditions are not met 

    The hook afterUpdateCatalogProduct should not execute the callback in the search mongo package if options are not provided.
    @willopez
    willopez committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    34e5942 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary collection hooks mocking in tests

    @willopez
    willopez committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    42a4dcf View commit details
    Browse the repository at this point in the history

  4. Fix: Not returning the constant in a hook was causing the publishing … 

    …flow to break down
    @willopez
    willopez committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    8f20d0e View commit details
    Browse the repository at this point in the history

  5. Refactor: Return constant in hooks 

    As a best practice in reaction hooks the constant should always be returned; this will prevent unexpected undefined errors from occurring when a hook has multiple callbacks.
    @willopez
    willopez committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    198d3df View commit details
    Browse the repository at this point in the history

  6. WIP: Remove inventory after archiving a variant

    @willopez
    willopez committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    8712344 View commit details
    Browse the repository at this point in the history

  7. fix: remove field limit

    @mikemurray
    mikemurray committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    a271713 View commit details
    Browse the repository at this point in the history

  8. fix: parse field to number 

    Field may be a string so it's parsed to an integer.
    @mikemurray
    mikemurray committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    2eb009b View commit details
    Browse the repository at this point in the history

  9. fix: incorrect inventory adjustment due to a stale document 

    To ensure the product document isn't stale, fetch a fresh copy before running inventory adjustments.
    @mikemurray
    mikemurray committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    45017ce View commit details
    Browse the repository at this point in the history

  10. refactor: fetch a fresh product for search document 

    To ensure the product document isn't stale, fetch a fresh copy before processing it for search.
    @mikemurray
    mikemurray committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    c23e65f View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2018

  1. Merge remote-tracking branch 'origin/release-1.10.0' into ref-3865-ki… 

    …eckhafer-inventoryCollectionHooks
    @kieckhafer
    kieckhafer committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    8e61bb9 View commit details
    Browse the repository at this point in the history

  2. add better typecheck to functions for tests

    @kieckhafer
    kieckhafer committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    3e3f105 View commit details
    Browse the repository at this point in the history

  3. add parseInt to make sure inventory doesn't dispaly string

    @kieckhafer
    kieckhafer committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    043ee13 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2018

  1. refactor: fix lint issues

    @mikemurray
    mikemurray committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    9003deb View commit details
    Browse the repository at this point in the history