migrate schemas API to an npm package #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* release-1.11.0: (102 commits) chore: fix dependency issue chore(CircleCI): refresh node_modules cache on package-lock changes feat(Security): update some packages to get security fixes feat(Security): update some packages to get security fixes fix(GraphQL): currency type improvements fix: keep setProfileCurrency method args backwards compatible tests(GraphQL): finish remaining tags tests fix(GraphQL): handle both cursor types tests(GraphQL): add tests for tags queries fix(GraphQL): no auth necessary for tags query feat(GraphQL): initial tags resolvers feat(GraphQL): initial Tag schema (fix) Remove _sleepForMs from tests docs(GraphQL): add some missing schema docs chore: ignore snyk warnings with no fix chore: update changelog for v1.11 chore: update package-lock.json feat: non-meteor version of hasPermission feat: created a networks config in docker-compose, added new networks to the devserver and reaction services Bug Fix: s/`in`/`.indexOf` ... # Conflicts: # package-lock.json
aldeed
previously requested changes
Apr 11, 2018
There was a problem hiding this comment.
@jshimko There are three shopify files that have this line in them:
import { registerSchema } from "/imports/plugins/core/collections";Those should be changed to import from the package.
Also you should delete the plugins/core/collections folder, or change it to have just the index.js and re-export the package imports.
* release-1.11.0: refactor(GraphQL): move Group resolvers to account section tests(GraphQL): fix tests refactor(GraphQL): transform types using resolvers update Hooks imports migrate Hooks API to an npm package # Conflicts: # package.json
* release-1.11.0: chore: resolve snyk warnings chore: fix Dockerfile lint chore: always npm install before starting docker services refactor(GraphQL): switch to .graphql files for schema package lock update update snyk for node-loggly-bulk fix failing test in graphql package update Logger package name restore Logger for jest test extract Logger API into new npm package
|
@aldeed Requested changes have been made. Let me know if you see anything else. Thanks! |
aldeed
approved these changes
Apr 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
Issue
We're currently working on migrating as many plugins/API's to npm as possible.
Solution
Move entire
SchemasAPI to an npm package and update imports to use it.Breaking changes
None expected.
Testing
Start Reaction and note that everything still works.
Available imports...
Also note that there's nothing Reaction-specific about the new package, so you could literally use it in any Node/javascript app.