Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4152: Currency as object #4156

Merged
merged 2 commits into from Apr 18, 2018
Merged

Conversation

Akarshit
Copy link
Contributor

@Akarshit Akarshit commented Apr 5, 2018

Resolves #4152
Impact: major
Type: bugfix

Issue

  1. The findCurrecny function was returning shop.currency when it was unable to find the user's currency. But that function is supposed to return an object of type Currency.
  2. While animating the background of input, a undefined value was being passed. This was happening because ref prop was not being set on the input inside NumericInput component.

Solution

  1. Made the function to return shop.currencies[shop.currency], which is the actual value expected.
  2. Passed ref=input to NumericInput.

Breaking changes

None

Testing

  1. Reset reaction
  2. Login as admin
  3. Create a product
  4. Click on the first variant so that the variant/option panel opens
  5. Observe no error in console
  6. After updating the price, observe no error about undefined promise.

Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Verified fixed

@spencern spencern merged commit a731a61 into release-1.11.0 Apr 18, 2018
@spencern spencern deleted the fix-4152-prop-variant-form branch April 18, 2018 22:15
@spencern spencern mentioned this pull request Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants