Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4152
Impact: major
Type: bugfix
Issue
findCurrecny
function was returningshop.currency
when it was unable to find the user's currency. But that function is supposed to return an object of typeCurrency
.input
, a undefined value was being passed. This was happening because ref prop was not being set on theinput
insideNumericInput
component.Solution
shop.currencies[shop.currency]
, which is the actual value expected.ref=input
to NumericInput.Breaking changes
None
Testing