Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4437: Ensure method hooks always run with correct timing (before and after method) #4537

Merged
merged 6 commits into from
Aug 14, 2018
Merged

#4437: Ensure method hooks always run with correct timing (before and after method) #4537

merged 6 commits into from
Aug 14, 2018

Commits on Aug 13, 2018

  1. (fix): await for result in methods that use graphql mutations, so met… 

    …hod hooks are fired correctly
    @dancastellon
    dancastellon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    5a2895f View commit details
    Browse the repository at this point in the history

  2. (fix): MethodHooks - await for before/after hook callbacks & method i… 

    …tself
    @dancastellon
    dancastellon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    6d9ff35 View commit details
    Browse the repository at this point in the history

  3. (style): eslint issues

    @dancastellon
    dancastellon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    cbfb448 View commit details
    Browse the repository at this point in the history

  4. (fix): allow before MethodHooks to prevent method from running + use … 

    …logger
    @dancastellon
    dancastellon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    123c21d View commit details
    Browse the repository at this point in the history

  5. (fix): prevent before MethodHooks from being able to prevent main met… 

    …hod execution
    @dancastellon
    dancastellon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    042469b View commit details
    Browse the repository at this point in the history

  6. (fix): DO let before MethodHooks return early, prevent check() error

    @dancastellon
    dancastellon committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    7cba6f8 View commit details
    Browse the repository at this point in the history