feat 4571 Replace all Meteor.userId() with util function

[impactmass]

Resolves #4571
Impact: minor
Type: chore

Issue

Goal: As a first step towards being able to replace Meteor's Accounts package, we want to wrap all existing calls to Meteor.userId in a function. Thus establishing an 'API' to retrieve logged in user ID that can be customized in the future.

Work

• Added of a getUserId() function on the client and server exports of Reaction namespace. It returns the value of Meteor.userId().

• Replaces all usage of Meteor.userId() with Reaction.getUserId()

• Marked existing reaction/getUserId method as deprecated. Reaction.getUserId should be used instead

• Extras

  • Removes an old getGuestLoginState function that was marked for removal in release 1.5.6. It was removed here as it uses the Meteor.userId method we're moving from.

Breaking changes

Core functionality of the app is untouched, but here's a potentially breaking update:

• Removal of the deprecated getGuestLoginState. This is/was an internal function, but in case anyone has plugin(s) using it, please update. This logic in this function can be recreated with the Roles package if needed.

A note to Plugin maintainers:

• With this update, take note that you should start moving away from calling Meteor.userId directly in your code. getUserId() should be used instead. Although this is not a breaking change as your existing plugins with Meteor.userId() will still work, this marks Reaction's initial set of steps to move away from Meteor accounts system. In coming releases, the internal setup of getUserId() will change. When that happens it will be listed as a breaking change for you to take note.

Testing

• This does not add any specific feature, so the test here is to confirm that the app still works as usual, no regression!

[nnnnat]

👍 Looks good!