Fix aldeed reaction error swallowing #4592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: bugfix
Issue
When migrations run in staging, there seem to be errors getting swallowed. The migrations stop at version 24 but no errors are printed.
Solution
Promise.await
in mutations in try/catch with loggingReactionError
to be essentially the same, but without relying on thees6-error
NPM package. This will help rule out that extra layer of inheritance as the cause of the error swallowing.Breaking changes
None
Testing
There is no great way to test this unless you manually add some error throwing in one of the awaited functions. As long as all automatic tests are still passing, just a code review of this PR should suffice.