Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aldeed reaction error swallowing #4592

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Aug 31, 2018

Impact: minor
Type: bugfix

Issue

When migrations run in staging, there seem to be errors getting swallowed. The migrations stop at version 24 but no errors are printed.

Solution

  • Wrapped all Promise.await in mutations in try/catch with logging
  • Updated ReactionError to be essentially the same, but without relying on the es6-error NPM package. This will help rule out that extra layer of inheritance as the cause of the error swallowing.

Breaking changes

None

Testing

There is no great way to test this unless you manually add some error throwing in one of the awaited functions. As long as all automatic tests are still passing, just a code review of this PR should suffice.

Remove es6-error NPM package and do what it was doing manually.
This might not fix issues, but it makes it easier to debug.
@aldeed aldeed requested a review from nnnnat August 31, 2018 19:56
@aldeed aldeed self-assigned this Aug 31, 2018
@aldeed aldeed added this to the Little Bear milestone Aug 31, 2018
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nnnnat nnnnat merged commit 89cd127 into release-1.16.0 Aug 31, 2018
@spencern spencern mentioned this pull request Sep 5, 2018
@aldeed aldeed deleted the fix-aldeed-reaction-error-swallowing branch December 17, 2018 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants