Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update graphql packages to support extend enum and extend union #4798

Merged
merged 4 commits into from Nov 15, 2018
Merged

Update graphql packages to support extend enum and extend union #4798

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
968e49e
(chore) update graphql packages
Nov 9, 2018
36b4972
(chore) correct the description for PaymentData
Nov 9, 2018
cdf514e
(fix) remove redundant PaymentMethodName
Nov 12, 2018
4aa953c
test: adjust unit test expectations for updated GraphQL pkgs
aldeed Nov 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions imports/plugins/core/payments/server/no-meteor/schemas/schema.graphql
View file
Open in desktop
Expand Up @@ -55,14 +55,14 @@ type ExampleIOUPaymentData {
fullName: String!
}

# These should be defined in their respective plugin schemas, but `extend union` isn't working yet
union PaymentData = ExampleIOUPaymentData | StripeCardPaymentData | MarketplaceStripeCardPaymentData
# Use `extend union` to define a payment plugin's PaymentData type
"Data identifying a payment for an order"
union PaymentData = ExampleIOUPaymentData

# These should be defined in their respective plugin schemas, but `extend enum` isn't working yet
# Use `extend enum` to add a plugin's payment method name
"The name of a payment method, which is how payment methods are keyed"
enum PaymentMethodName {
iou_example
stripe_card
zenweasel marked this conversation as resolved.
Show resolved Hide resolved
}

"An example"
Expand Down
33 changes: 26 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -68,12 +68,12 @@
"fibers": "^2.0.0",
"flatten-obj": "^3.1.1",
"font-awesome": "^4.7.0",
"graphql": "0.13.1",
zenweasel marked this conversation as resolved.
Show resolved Hide resolved
"graphql": "14.0.2",
"graphql-fields": "1.1.0",
"graphql-iso-date": "3.5.0",
"graphql-relay": "0.5.5",
"graphql-tag": "2.9.2",
"graphql-tools": "3.1.1",
"graphql-tools": "4.0.3",
"graphql.js": "0.4.20",
"handlebars": "^4.0.11",
"history": "^4.7.2",
Expand Down