load account into context during surcharges #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Birk <cmbirk@gmail.com>
cmbirk
force-pushed
the
fix-member-taxes
branch
from
f441b15
to
04e29ca
Compare
aldeed
requested changes
Aug 19, 2019
| if (cart.accountId && !context.account) { | ||
| const { Accounts } = context.collections; | ||
| const account = await Accounts.findOne({ _id: cart.accountId }); | ||
| context.account = account; |
There was a problem hiding this comment.
The cart account may not be the same as the request account, and may have different permissions. Also, by mutating the “base” context, this value might stick around longer than you’re expecting and be used in subsequent event handler calls.
If you instead do contextWithAccount = { ...context, account, accountId: cart.accountId }; and then pass through contextWithAccount instead of context below, that's safe, though potentially not the best fix in the long run.
There was a problem hiding this comment.
Should be fixed in bdc57ed
Signed-off-by: Chris Birk <cmbirk@gmail.com>
cmbirk
force-pushed
the
fix-member-taxes
branch
from
bdc57ed
to
0af4a9a
Compare
|
@aldeed this should be good to go. Have tested that member priced items can go through the entire checkout flow |
aldeed
approved these changes
Aug 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR here: https://github.com/sportsdirect/reaction/pull/498
Resolves(but doesn't close) sportsdirect/reaction-plugin-pricing-engine#48
Impact: critical
Type: bug
Issue
Loads the account into the context object in the surcharges afterCartUpdate event. This is needed in context to choose the correct price in getVariantPrice from the pricing engine. It was previously calculating tax based on the full priced item instead of the member price, which was causing a mismatch at checkout time of the expected pricing.
cc @rosshadden @jrphilo @kkuzemka