Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.0] Use api-utils for currency definitions #5823

Merged
merged 5 commits into from Nov 22, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Nov 21, 2019

Resolves #5822
Impact: breaking
Type: feature|bugfix

Issue

Earlier in the 3.0.0 release, we stopped setting shop.currencies because it was the same for every shop. We also removed most of the exchange rates feature because it was poorly implemented. But there were still some places in the code checking shop.currencies.

Solution

Remove remaining use of shop.currencies.

  • Update setAccountProfileCurrency gql mutation to use CurrencyDefinitions from api-utils package instead of shop.currencies
  • Remove exchange rate handling from placeOrder. It was only half implemented and never tested, and it relied on shop.currencies
  • Update publishProductToCatalog mutation function to use CurrencyDefinitions from api-utils package instead of shop.currencies
  • Update simple-pricing plugin to no longer include currencyExchangePricing object on prices. This was effectively broken by earlier changes removing exchange rate updating and it relied on shop.currencies

Breaking changes

The currencyExchangePricing field is no longer available on ProductPricingInfo type in GraphQL (simple-pricing plugin)

Testing

Main areas of testing:

  • placing an order works
  • publishing a product to catalog works

… api-utils

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed aldeed self-assigned this Nov 21, 2019
@aldeed aldeed added this to In progress in 3.0.0 via automation Nov 21, 2019
@aldeed aldeed moved this from In progress to Review in progress in 3.0.0 Nov 21, 2019
3.0.0 automation moved this from Review in progress to Reviewer approved Nov 22, 2019
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 able to perform the actions i wasn't able to before this PR

@kieckhafer kieckhafer merged commit cb4925f into release-3.0.0 Nov 22, 2019
3.0.0 automation moved this from Reviewer approved to Done Nov 22, 2019
@kieckhafer kieckhafer deleted the fix-aldeed-5822-currencies branch November 22, 2019 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants