Adjust the sharp syntax #5881
Merged
Adjust the sharp syntax #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janus Reith janus.reith@googlemail.com
Resolves #5803
Impact: critical
Type: bugfix
Issue
sharpwas updated from^0.20.5to~0.23.1.The way resizing works changed in sharp
v0.22.0.Solution
Adjust the syntax accordig to the sharp docs. The conversions for each store should work the same, except for the additional
withoutEnlargementoption. I also added an event handler that takes care of throwing aReactionErroron error.Breaking changes
Due to
withoutEnlargementoption the images that are smaller than the dimensions set on each store won't be scaled up anymore and therefore don't take up additional space without providing a better quality.Testing
TBD - Could use the remoteUrlWorker and place a record in the
cfs.Media.filerecordcollection.