Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds integration test updateGlobalSettings mutation #5970

Merged
merged 11 commits into from Jan 7, 2020
Merged

adds integration test updateGlobalSettings mutation #5970

merged 11 commits into from Jan 7, 2020

Conversation

willopez
Copy link
Member

Resolves #5950
Impact: minor
Type: chore | test

Summary

Adds integration test for updateGlobalSettings mutation

@willopez
refactor: remove unnccessary file
348c268 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
chore: add updateGlobalSettings mutation integration test
1bf5d37 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
fix: looks in the correct object for customs global settings
0dc7ac4 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@kieckhafer
Copy link
Member

This seems like the same issue here: #5974 (comment)

@willopez
refactor: add missing await
2a30e8b 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
Copy link
Member Author

@kieckhafer This a new issue, I believe the root cause it the fact that the shopId is undefined for global settings, and that case is not currently handled in the validatePermissions function

@willopez
Merge branch 'release-3.0.0' into chore-integration-test-updateGlobal…
ec6d1f8 
…Settings
@willopez
refactor: check for shop id when validating permissions for global
9a35ad7 
settings

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
Merge branch 'release-3.0.0' into chore-integration-test-updateGlobal…
5c867be 
…Settings
@willopez
refactor: use global roles
1ab981a 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
refactor: correctly merge a user's global settings
51cb76d 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez
chore: complete test
bde3118 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez requested review from aldeed and removed request for kieckhafer January 2, 2020 22:46
@willopez willopez marked this pull request as ready for review January 2, 2020 22:46
@willopez
fix: lint error
13881f2 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@aldeed aldeed merged commit 989ae9c into release-3.0.0 Jan 7, 2020
@aldeed aldeed deleted the chore-integration-test-updateGlobalSettings branch January 7, 2020 17:35
@rosshadden rosshadden mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldeed aldeed aldeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willopez @kieckhafer @aldeed