Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use functionsOfType to register multiple auth permissions functions #6009

Merged
merged 5 commits into from Jan 13, 2020
Merged

refactor: use functionsOfType to register multiple auth permissions functions #6009

merged 5 commits into from Jan 13, 2020

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jan 7, 2020 •
edited

Impact: minor
Type: feature|refactor

Issue

Reaction currently allows only one active getHasPermissionFunctionForUser function to be registered, therefore only allowing one authorization service check.

Solution

Update context.userHasPermission to allow multiple authorization services to be registered and checked against.

Breaking changes

None.

Testing

  1. Start the app
  2. See that the existing legacy-authorization package works as is expected
  3. Further expansion on this will come in more auth-pod work

@kieckhafer kieckhafer changed the title refactor: use functionsOfType to register multiple auth permissions functions [WIP] refactor: use functionsOfType to register multiple auth permissions functions Jan 8, 2020
@kieckhafer
refactor: update curry function with new number of expected params
66c14da 
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@kieckhafer
test: add getFunctionsOfType to context tests
3ca1b56 
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@kieckhafer kieckhafer changed the title [WIP] refactor: use functionsOfType to register multiple auth permissions functions refactor: use functionsOfType to register multiple auth permissions functions Jan 8, 2020
@kieckhafer kieckhafer merged commit 2841f3b into release-3.0.0 Jan 13, 2020
@kieckhafer kieckhafer deleted the feat-kieckhafer-registerMultiplePermissionsPlugins branch January 13, 2020 21:20
@kieckhafer kieckhafer mentioned this pull request Jan 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosshadden rosshadden rosshadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kieckhafer @rosshadden