Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update filename extension to work with esmodules #6291

Merged
merged 2 commits into from Sep 24, 2020

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Sep 24, 2020

Issue

GraphQL linting was throwing an error because of the way require works with esmodules

Solution

Rename the affected file to .cjs to make it work.

Breaking changes

n/a

Testing

  1. See tests pass

Signed-off-by: Erik Kieckhafer <ek@ato.la>
This was referenced Sep 24, 2020
@kieckhafer kieckhafer changed the title update filename extension to work with esmodules chore: update filename extension to work with esmodules Sep 24, 2020
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@focusaurus focusaurus merged commit a262296 into node14 Sep 24, 2020
@focusaurus focusaurus deleted the node14-cjs-fix branch September 24, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants