Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve apply coupon mutation #6735

Merged
merged 1 commit into from
Jan 30, 2023
Merged

feat: improve apply coupon mutation #6735

merged 1 commit into from
Jan 30, 2023

Conversation

vanpho93
Copy link
Member

Resolves #6725
Impact: major
Type: feature

Issue

Outdated schema for coupon
Missing usage limit per coupon

Solution

Update schema
Add limit check

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022 •
edited

⚠️ No Changeset found

Latest commit: f65959b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch 3 times, most recently from 859f8a4 to ba5d620 Compare December 29, 2022 09:36
@zenweasel
Copy link
Collaborator

@vanpho93 Have conflicts here

@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch 5 times, most recently from 51cb90b to e491cfd Compare January 4, 2023 03:33
@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch 3 times, most recently from 1f5210c to 00059cc Compare January 5, 2023 14:39
@vanpho93
feat: improve apply coupon mutation
f65959b 
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch from 00059cc to f65959b Compare January 30, 2023 01:55
@vanpho93 vanpho93 merged commit db17285 into feat/create-standard-coupon Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenweasel zenweasel zenweasel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanpho93 @zenweasel