Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove coupon from cart mutation #6736

Conversation

vanpho93
Copy link
Member

Resolves #6728
Impact: major
Type: feature

Solution

Remove promotion from appliedPromotions then reapply promotions

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

⚠️ No Changeset found

Latest commit: e1353bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch from 43f6017 to 859f8a4 Compare December 29, 2022 09:22
@vanpho93 vanpho93 force-pushed the feat/add-remove-coupon-from-cart-mutation branch from e39ecbe to b161d79 Compare December 29, 2022 09:28
@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch from 859f8a4 to ba5d620 Compare December 29, 2022 09:36
@vanpho93 vanpho93 force-pushed the feat/add-remove-coupon-from-cart-mutation branch 2 times, most recently from a8dc1f5 to 6659ff3 Compare December 29, 2022 09:57
@vanpho93 vanpho93 force-pushed the feat/add-remove-coupon-from-cart-mutation branch from 194cc96 to e92b3af Compare December 30, 2022 08:21
zenweasel
zenweasel previously approved these changes Jan 3, 2023
@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch 5 times, most recently from 7de9ce8 to b698c5d Compare January 5, 2023 14:00
@vanpho93 vanpho93 force-pushed the feat/improve-apply-coupon-mutation branch from 00059cc to f65959b Compare January 30, 2023 01:55
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93 vanpho93 force-pushed the feat/add-remove-coupon-from-cart-mutation branch from e92b3af to e1353bd Compare January 30, 2023 01:57
@vanpho93 vanpho93 changed the base branch from feat/improve-apply-coupon-mutation to feat/create-standard-coupon January 30, 2023 03:38
@vanpho93 vanpho93 dismissed zenweasel’s stale review January 30, 2023 03:38

The base branch was changed.

@vanpho93 vanpho93 merged commit 13b876e into feat/create-standard-coupon Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants