feat: add additional coupon validation #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vanpho93
force-pushed
the
feat/add-additional-coupon-validation
branch
7 times, most recently
from
2b193d7
to
a3764f2
Compare
Signed-off-by: vanpho93 <vanpho02@gmail.com>
vanpho93
force-pushed
the
feat/add-additional-coupon-validation
branch
from
a3764f2
to
366a11a
Compare
zenweasel
approved these changes
Feb 6, 2023
|
|
||
| const now = new Date(); | ||
| if (promotion.startDate <= now) { | ||
| throw new ReactionError("invalid-params", "This coupon cannot be edited because the promotion is on the window time"); |
There was a problem hiding this comment.
We need to improve the wording of this since I can't tell what this means
Signed-off-by: vanpho93 <vanpho02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vanpho93 vanpho02@gmail.com
Resolves #6724
Impact: major
Type: featuree
Solution